fix: properly load dbt relation type for get_relation() and related functions#5144
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the proper loading of dbt relation types for get_relation() and related functions by ensuring that relation type information (table vs view) is correctly populated when retrieving data objects.
- Refactored
_data_object_to_relation()method to centralize relation creation logic - Updated
load_relation()to use data object information when available for proper type detection - Enhanced test coverage to verify relation type detection for both tables and views
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sqlmesh/dbt/adapter.py | Refactored relation creation logic and updated load_relation() to properly detect relation types |
| tests/dbt/test_adapter.py | Added test coverage for relation type detection and updated existing test expectations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
newtonapple
commented
Aug 13, 2025
newtonapple
commented
Aug 13, 2025
newtonapple
force-pushed
the
ddai/issue-1987
branch
from
August 13, 2025 07:51
01ccf3e to
3202822
Compare
newtonapple
commented
Aug 13, 2025
newtonapple
force-pushed
the
ddai/issue-1987
branch
3 times, most recently
from
August 14, 2025 06:36
6551469 to
4696ebe
Compare
related functions fixes #1987
newtonapple
force-pushed
the
ddai/issue-1987
branch
from
August 14, 2025 16:18
4696ebe to
46b811b
Compare
newtonapple
marked this pull request as ready for review
August 14, 2025 21:59
izeigerman
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1987