Fix!: sqlmesh.dbt.adapter.RuntimeAdapter.get_columns_in_relation()#5115
Merged
Conversation
newtonapple
commented
Aug 8, 2025
newtonapple
force-pushed
the
ddai/issue-1874
branch
from
August 8, 2025 08:40
dece00e to
010dbc2
Compare
izeigerman
reviewed
Aug 8, 2025
izeigerman
reviewed
Aug 9, 2025
Collaborator
|
Thanks for clarifying. This looks good. How do we test this? |
Contributor
Author
I added an integration test for |
Contributor
Author
Actually, I think I can mock it out. |
newtonapple
marked this pull request as ready for review
August 11, 2025 22:05
returns columns in the proper Column subclass type. fixes #1874
newtonapple
force-pushed
the
ddai/issue-1874
branch
from
August 11, 2025 22:06
24fd2d4 to
8f7f061
Compare
newtonapple
force-pushed
the
ddai/issue-1874
branch
from
August 11, 2025 22:38
8f7f061 to
96ea438
Compare
izeigerman
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
returns columns in the proper Column subclass type.
fixes #1874