Open
Conversation
ahobeost
reviewed
Nov 26, 2025
Contributor
ahobeost
left a comment
ahobeost
left a comment
There was a problem hiding this comment.
@nehadimri1991: Could you please explain the two things here?
| if "districtHeatingInBus" + '__Building' + str(b + 1) in self._busDict: | ||
| busesOut.append(self._busDict["districtHeatingInBus" + '__Building' + str(b + 1)]) | ||
| busesIn.append(self._busDict["districtHeatingBus" + '__Building' + str(b + 1)]) | ||
| if "districtHeatInBus" + '__Building' + str(b + 1) in self._busDict: |
Contributor
There was a problem hiding this comment.
Could you explain where the warning is coming from?
This restriction should be lifted in the future
Contributor
There was a problem hiding this comment.
venv\Lib\site-packages\openpyxl\workbook\child.py:99: UserWarning: Title is more than 31 characters. Some applications may not be able to read the file
warnings.warn("Title is more than 31 characters. Some applications may not be able to read the file")| # TODO: refactor into functions | ||
| if 'GenericStorage' in label_prefix: | ||
| typical_losses = {'tank': 0.10, 'pit': 0.20, 'borehole': 0.15, 'aquifier': 0.001} | ||
| typical_losses = {'tank': 0.00011, 'pit': 0.00011, 'borehole': 0.00011, 'aquifier': 0.00011} |
Contributor
There was a problem hiding this comment.
The scenario_pit.xls includes a capacity loss value, which does not seem to connect to anything in this _precalculate function.
The scenario files in the other repository use this capacity loss value and set it to zero.
Is this capacity loss value connected to anything?
Why do you change the typical losses here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.