Skip to content

fix: undo redo opens invalid class editor (RDFA-499)#133

Open
rema-soptim wants to merge 4 commits into
mainfrom
fix/RDFA-499-undo-redo-opens-invalid-class-editor
Open

fix: undo redo opens invalid class editor (RDFA-499)#133
rema-soptim wants to merge 4 commits into
mainfrom
fix/RDFA-499-undo-redo-opens-invalid-class-editor

Conversation

@rema-soptim
Copy link
Copy Markdown
Collaborator

@rema-soptim rema-soptim commented Jun 2, 2026

Description

  • before opening the classeditor the classeditor checks if the class its trying to open exists
  • dialogs now block undo redo functionality, to ensure consistent behaviour

Test Checklist

General Behavior

  • Components reload automatically when data changes
  • Editing features are disabled in readonly datasets
  • Dialogs pre-select current dataset/graph
  • Required fields are validated in dialogs
  • Discarding unsaved changes opens a discard cancel confirm dialog

Global MenuBar

  • Navigate to home page works
  • File menu:
    • Import → Graph/SHACL works
    • Export → Graph/SHACL works
    • Share Snapshot works
    • Delete → Dataset/Graph works
  • Edit menu:
    • New → Class works
    • New → Package works
    • Edit/View → Create/Edit/View Ontology works
    • Edit/View → Package works
    • Undo/Redo (Ctrl+Z / Ctrl+Y) works
    • Enable/Disable editing works
    • Manage/View namespaces works
    • Delete → Ontology/Package works
  • View menu:
    • Changelog opens and shows current graph
    • Compare Graphs opens
    • Full SHACL works
  • Help menu:
    • Help link works
    • Submit Feedback link works
    • About navigation works

Welcome Page

  • Navigation to Editor works
  • Tips are displayed
  • Security and data information displayed
  • Copyright and version information displayed

Editor - MenuBar

  • Search function works with all filters (All Datasets, Current Dataset, Current Graph, Current Package)
  • Search finds classes, attributes, associations, packages
  • "Enable Editing" button appears for readonly datasets

Editor - Navigation

  • Hierarchical display (Datasets → Graphs → Packages) works
  • Selection is highlighted
  • Selecting a class does not change dataset/graph/package selection
  • Class selection stays open/highlighted when switching dataset/graph/package
  • Datasets and graphs are collapsible
  • Single click selects; double click or chevron toggles expand/collapse
  • State persists on reload (non-browser)
  • Context menus act on the dataset/graph/package they were opened on
  • Hover labels show prefixes when configured
  • Dataset context menu:
    • Import graph works (disabled in readonly datasets)
    • Share Snapshot works
    • Enable/Disable editing works
    • Manage/View namespaces works
    • Delete dataset works
  • Graph context menu:
    • New package works (disabled in readonly datasets)
    • Undo/Redo works (only enabled when available)
    • Create Ontology
    • Edit Ontology (View Ontology in readonly)
    • Delete Ontology
    • Changelog navigation works
    • Compare dialog works
    • SHACL import/export/full view works (import disabled in readonly datasets)
    • Export graph works
    • Delete graph works (disabled in readonly datasets)
  • Package context menu:
    • Create new class works (disabled in readonly datasets)
    • View/Edit package works
    • Copy URL works
    • Delete package works (disabled for external/default packages and readonly datasets)
  • Class context menu:
    • Open class (editor) works
    • SHACL works
    • Delete class works (disabled in readonly datasets)

Editor - Package View

  • Class diagram displays correctly
  • Moving nodes works and layout changes persist after reload
  • Loading animation shows while loading
  • Info cards show when no package or no classes available
  • Drag and zoom diagram works
  • "Reset View" button works
  • "Filter View" works
  • "Reset Layout" button resets diagram to auto-generated layout
  • Click on class opens class editor

Editor - Class Editor

  • Display and edit class properties: Label, Namespace, Package, Derived from, Abstract, Stereotypes, Attributes, Associations, Comment
  • Delete class works
  • Save changes works
  • Discard changes works
  • Attribute Editor works
  • Association Editor works
  • attribute/association SHACL View works
  • Class SHACL View works

Prefixes Page

  • View, add, remove and edit namespaces works

Changelog Page

  • Select graph and display write operations works
  • Operations shown in reverse chronological order
  • Detailed view of changed triples works
  • Restoring graph to a version works

Compare Page

  • Compare two graphs works

@rema-soptim rema-soptim force-pushed the fix/RDFA-499-undo-redo-opens-invalid-class-editor branch from 4d52df9 to 4c5f937 Compare June 2, 2026 15:04
spah-soptim
spah-soptim requested changes Jun 2, 2026
View reviewed changes
Comment thread frontend/src/routes/mainpage/classEditor/classEditor.svelte
onDestroy(() => eventStack.removeEvent(closeClassEditor));
function withUnsavedChangesCheck(action) {
if (reactiveClass?.isModified) {
pendingAction = action;
Copy link
Copy Markdown
Member

@spah-soptim spah-soptim Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

withUnsavedChangesCheck sets pendingAction and opens the dialog, but cancel (closeDialog(onCancel)) and escape never clear pendingAction.

Comment thread frontend/src/routes/+layout.svelte
Comment on lines +233 to +247
if (isRedo) {
if (canRedo && (await redo())) {
await reload();
toastStore.info("Redone");
} else if (!canRedo) {
console.log("Redo blocked: nothing to redo.");
}
} else {
if (canUndo && (await undo())) {
await reload();
toastStore.info("Undone");
} else if (!canUndo) {
console.log("Undo blocked: nothing to undo.");
}
}
Copy link
Copy Markdown
Member

@spah-soptim spah-soptim Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo/redo are now wrapped in eventStack.guardAction(...) with no return, so they now always resolve to undefined.
So await reload() and toast notifications are now dead.
Reload is still covered with a forceReloadtrigger.trigger() internally, but reload() also did editorState.selectedDataset/Graph/ClassUUID.trigger() and fetchUndoRedo().
But no longer the toasts.

Comment thread frontend/src/lib/actions/versionControlActions.js Outdated
console.log("Undo failed.");
toastStore.error("Undo failed", "Could not undo the last change.");
return false;
eventStack.guardAction(async () => {
Copy link
Copy Markdown
Member

@spah-soptim spah-soptim Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RDFArchitect/frontend/src/routes/mainpage/packageNavigation/GraphSection.svelte

Line 189 in 4c5f937

if (success) forceReloadTrigger.trigger();

GraphSection still relies on the return value.

Comment thread frontend/src/routes/mainpage/classEditor/classEditor.svelte Outdated
isDatasetReadOnly = await isReadOnly(datasetName);
await loadContext();
await loadReactiveClass(cancellation);
await loadReactiveClass(cancellation, JSON.parse(resText));
Copy link
Copy Markdown
Member

@spah-soptim spah-soptim Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!resText handles empty body, not non-empty, non-JSON body.
Maybe try/catch.

Comment thread frontend/src/lib/eventhandling/closeEventManager.svelte.js Outdated
}

unregisterActionGuard() {
this.actionGuard = null;
Copy link
Copy Markdown
Member

@spah-soptim spah-soptim Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe only unregister if actionGuard === fn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spah-soptim spah-soptim spah-soptim requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rema-soptim @spah-soptim