Skip to content

Issue Fix - #508

Merged
IbrahimIjai merged 4 commits into
SO4-Markets:mainfrom
razeprasine:main
Jul 30, 2026
Merged

Issue Fix#508
IbrahimIjai merged 4 commits into
SO4-Markets:mainfrom
razeprasine:main

Conversation

@razeprasine

Copy link
Copy Markdown
Contributor

Summary
Four design-system tickets shipped across packages/ui and apps/web. The theme is hardening — release tooling, RTL readiness, locale correctness, and table accessibility.

Commits

  1. Add a design-system release checklist and change log (d0293d3)
  • packages/ui/CHANGELOG.md — changelog with dates, links, conventional-commits headings
  • .github/PULL_REQUEST_TEMPLATE/design-system.md — PR template with checklist for visual regression, accessibility, responsive testing
  • packages/ui/CONTRIBUTING.md — added pnpm test instructions, commit conventions
  1. Audit layouts for RTL and logical CSS properties (e242e90)
    47 files, ~230 insertions. Replaced hard-coded physical properties with logical equivalents across the entire design system and app:
  • left/right → inset-inline-start/inset-inline-end
  • border-l/border-r → border-inline-start/border-inline-end
  • ml/mr/pl/pr → ms/me/ps/pe
  • text-left/text-right → text-start/text-end
  • DirectionProvider for toggling dir on
  • Gallery RTL toggle + visual test fixtures
  1. Centralize locale-aware number and date presentation (2c145d0)
    3 files, ~650 insertions. Rewrote format.ts with Intl APIs and consolidated numeric.tsx:
  • Intl.NumberFormat / Intl.DateTimeFormat / Intl.RelativeTimeFormat
  • Locale and currency params on all formatting functions
  • Negative-zero normalization, "less than" rounding strategy
  • Hydration-safe SSR fallback + tabular-nums enforcement
  • format.test.ts with two-locale coverage (en-US, de-DE)
  1. Responsive DataTable shell (6ae4397)
    2 files. Rebuilt data-table.tsx to compose table.tsx primitives instead of raw elements:
  • Loading state — proper with 3 skeleton rows (was flex
    )
  • Empty state —
  • + + (was standalone
    )
  • New align column prop maps to text-right on both
  • and
  • New selectedRowKey — matching row gets aria-current + bg-muted/30
  • 162-line test file covering render, alignment, loading, empty, selected, click, keyboard, overflow, and a11y
  • Files changed
    Stat Count
    Total files ~52
    Insertions ~1,200
    Deletions ~296
    packages/ui 13 files
    apps/web 36 files
    Other 3 files (.github/, e2e/)

    Closes #475
    Closes #473
    Closes #472
    Closes #421

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

@razeprasine is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 30, 2026

Copy link
Copy Markdown

@razeprasine Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@IbrahimIjai
IbrahimIjai merged commit 5e7095e into SO4-Markets:main Jul 30, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants