feat(ui): build accessible Toolbar component - #504
Merged
IbrahimIjai merged 1 commit intoJul 30, 2026
Conversation
- Implement WAI-ARIA Toolbar pattern with roving tabindex - Support horizontal and vertical orientation - Arrow-key navigation (Left/Right for horizontal, Up/Down for vertical) - Home/End keys move to first/last enabled control - Skip disabled controls during navigation - Only one control in tab order at a time Components: - Toolbar.Root: Main toolbar container with orientation support - Toolbar.Group: Semantic grouping with optional aria-label - Toolbar.Button: Interactive button with toggle state support - Toolbar.Link: Navigation link participating in keyboard flow - Toolbar.Separator: Visual divider respecting orientation Features: - Roving tabindex with arrow key navigation - Wrapping at boundaries - Dynamic item support (add/remove) - Disabled control handling - Toggle button states (pressed/unpressed) - Mixed controls (buttons + links) - Full test coverage (25 tests) Implements DS-081 acceptance criteria: ✓ Only one enabled toolbar control in tab order at a time ✓ Arrow keys follow orientation and skip disabled controls ✓ Home and End move to first and last enabled control ✓ Buttons, links, and separators retain correct semantics ✓ Tests cover orientations, disabled controls, focus movement
|
@dev-susa is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@dev-susa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements DS-081: Build an accessible Toolbar component (#492)
Implements a fully accessible WAI-ARIA Toolbar pattern with roving tabindex navigation, supporting horizontal/vertical orientations, keyboard controls, and dynamic items.
Implementation
Components
Keyboard Navigation
Features
✅ Roving tabindex with only one control in tab order
✅ Full arrow key navigation following orientation
✅ Home/End key support
✅ Disabled control handling (skipped during navigation)
✅ Toggle button states with
aria-pressed✅ Mixed controls (buttons + links)
✅ Dynamic item support (add/remove at runtime)
✅ Proper ARIA semantics (
role="toolbar",role="group")✅ Visual variants: default, outline, ghost
✅ Size variants: default, sm, icon, icon-sm
Testing
Usage Example
Acceptance Criteria
Out of Scope (as specified)
Closes #492