Skip to content

feat: add appearance settings panel (DS-065) - #500

Merged
IbrahimIjai merged 1 commit into
SO4-Markets:mainfrom
precious-akpan:feat/465-appearance-settings-panel
Jul 30, 2026
Merged

feat: add appearance settings panel (DS-065)#500
IbrahimIjai merged 1 commit into
SO4-Markets:mainfrom
precious-akpan:feat/465-appearance-settings-panel

Conversation

@precious-akpan

Copy link
Copy Markdown
Contributor

Summary

Implements a user-facing appearance settings panel with Light, Dark, and System theme options.

Changes

  • Added AppearanceSettingsPanel component with radio group controls
  • Shows resolved theme when System is selected
  • Real-time updates when system preferences change
  • Visual preview cards using semantic design tokens
  • Reuses existing ThemeProvider and storage
  • No page reload or flash on theme change

Features

  • ✅ Keyboard-accessible radio group with arrow key navigation
  • ✅ Persists selection to localStorage
  • ✅ Updates immediately without flash
  • ✅ Preview cards remain readable in both themes
  • ✅ Shows current system preference for transparency

Testing

  • Comprehensive test suite covering persistence, system resolution, keyboard selection
  • Preview cards are aria-hidden for screen readers
  • Accessible radio group with proper labeling

Closes #465

- Implement settings panel for Light/Dark/System theme selection
- Show resolved theme when System is selected
- Real-time updates when system preferences change
- Persist selection without page reload or flash
- Keyboard-accessible radio group
- Optional visual preview cards using semantic tokens
- Comprehensive test suite

Closes SO4-Markets#465
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

@precious-akpan is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 30, 2026

Copy link
Copy Markdown

@precious-akpan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@IbrahimIjai
IbrahimIjai merged commit 28f42a2 into SO4-Markets:main Jul 30, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DS-065: Add a user-facing appearance settings panel

2 participants