implemented - #505
Merged
Merged
Conversation
|
@Wilfred007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old event was (caller, prices.len()). In Soroban, events can publish tuples or structs. Changing from a tuple (Address, u32) to a struct PricesSubmittedBatch could break clients that are parsing the event. However, looking at the circuit breaker event as an example, it publishes a struct CircuitBreakerTripped. So it seems the codebase uses structs for events.
Actually, I think I should keep the old event format for backward compatibility AND add the new per-price events. Let me check what the old event actually was again... Oh wait, I already changed it. Let me revert that change and keep the old event format as is, while adding the new per-price events
Closes #439
Closes #414
Closes #252
Closes #415