fixed - #486
Merged
abayomicornelius merged 1 commit intoJul 24, 2026
Merged
Conversation
|
@Akatenvictor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a good PR message:
Title: fix: move
get_adl_eligible_positionsandestimate_swap_outputintoimpl ReaderBody:
Summary
get_adl_eligible_positionsandestimate_swap_outputwere declared inside#[cfg(test)] mod testsinstead of insideimpl Reader, meaning they were never compiled into the deployed WASM andSelf::get_market(...)would fail to resolve (E0433) outside the impl context. Both functions are now proper#[contractimpl]view methods on theReadercontract.get_funding_rate_infoindentation (was 8-space indented instead of 4-space like every other method).Changes
contracts/reader/src/lib.rsget_adl_eligible_positionsfrommod tests→impl Readerestimate_swap_outputfrommod tests→impl Readerget_funding_rate_infoblock indentation (8-space → 4-space)get_adl_eligible_positions_returns_profitabletestget_adl_eligible_positions_excludes_losingtestestimate_swap_output_empty_pathtestWhy
Frontend/integrator code expects these methods to be callable on the deployed contract. With the functions inside
#[cfg(test)], they were excluded from the release build entirely, and anycargo testreaching this crate hit a hard compile error onSelf.Note: I couldn't run
cargo checkdue to disk space (No space left on device), so you'll want to verify compilation locally before merging.Closes #395
Closes #403
Closes #404
Closes #396