fix: correct apply_delta_to_u128 signature to take &i128 (closes #407) - #483
Merged
abayomicornelius merged 1 commit intoJul 26, 2026
Conversation
…Markets#407) The IDataStore trait declared delta: i128 (owned) while every call site in the same file passes a reference (&fee_tokens, &net_collateral). Changed the trait declaration to delta: &i128 to match the Soroban client convention and all existing call sites.
|
@Obiajulu-gif Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #407
Summary
Changed the \IDataStore::apply_delta_to_u128\ trait declaration in \libs/increase_position_utils/src/lib.rs\ from \delta: i128\ (owned) to \delta: &i128\ (reference), matching the Soroban client convention and all existing call sites in the same file.
Problem
The trait declared \delta: i128\ while every call site passes references (&fee_tokens, &net_collateral). This mismatch could cause compilation errors depending on Soroban SDK version and client generation behavior.
Fix
Changed the trait parameter to \delta: &i128\ to match the convention used by all other call sites.