fix: exclude funding fee from pool_amount in decrease_position (closes #412) - #482
Merged
abayomicornelius merged 1 commit intoJul 26, 2026
Conversation
…SO4-Markets#412) total_cost_amount (borrowing + funding + position fees) was added entirely to pool_amount, double-booking the funding fee: the paying side's funding fee inflates LP-owned pool value while the counter side still claims the same tokens via the funding accumulator. Now only borrowing_fee_amount + position_fee_amount feed into pool_amount and claimable_fee_amount.
|
@Obiajulu-gif Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #412
Summary
In \decrease_position, only borrowing and position fees are added to \pool_amount. The funding fee is excluded because it is peer-to-peer and tracked separately via the funding accumulator.
Problem
\ otal_cost_amount\ (borrowing + funding + position fees) was added entirely to \pool_amount. This double-booked the funding fee: the paying side's funding fee inflated LP-owned pool value at close, while the counter side still independently claims the same tokens via the funding accumulator — without \pool_amount\ ever being decremented. Over time this systematically overstated the GM token price.
Fix
Changed \�pply_delta_to_pool_amount\ and \claimable_fee_amount_key\ to use \�orrowing_fee_amount + position_fee_amount\ instead of \ otal_cost_amount.