Conversation
c101088
commented
Nov 13, 2024
c101088
commented
- 引入CMake作为项目的构建工具
- 使用vcpkg管理项目的依赖包
- 引入gtest框架，配置简单的单元测试示例
2. 引入vcpkg作为包管理工具，安装依赖sundials 3. 引入GTest作为测试框架，给出简单示例
2. 新增编译说明
Author
|
macos的适配没有来得及做，先适配了windows和linux |
DankerMu
added a commit
that referenced
this pull request
Jun 28, 2026
…er UB)
FloodAlert dtor unconditionally `delete[] itype` + `fclose(fid)` regardless of
whether InitAlert/InitFile was ever called. With itype + fid declared without
default initializers, the values were undefined behavior — Mac happened to
zero them (so `if(itype!=NULL) delete[]` was a no-op), but Linux g++ left
garbage that passed the `!=NULL` check and triggered SEGV on `delete[]` of a
bogus pointer (and would also crash `fclose` on a stale fid).
The PR-0 spike binaries (dump_adjacency etc) construct Model_Data → loadinput
→ initialize but never invoke FloodAlert::InitAlert/InitFile (no flood mesh).
On Linux this guaranteed segfault during ~Model_Data → FreeData → ~FloodAlert.
ASan stack trace (sbatch run on cn-node, jobid 9759):
#4 in FloodAlert::~FloodAlert() src/classes/FloodAlert.cpp:29
#5 in Model_Data::FreeData() src/ModelData/MD_readin.cpp:688
#6 in Model_Data::~Model_Data() src/ModelData/Model_Data.cpp:20
#7 in main /scratch/.../tools/p8tune.D/dump_adjacency.cpp:433
Fix:
- hpp: int *itype = NULL; and FILE *fid = NULL;
- cpp: guard if(fid != NULL) fclose(fid); (consistency with other guards)
Zero impact on legacy shud/shud_omp flow that does call InitAlert + InitFile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.