Skip to content
This repository was archived by the owner on May 29, 2022. It is now read-only.
This repository was archived by the owner on May 29, 2022. It is now read-only.

Assert failing in debug build for MSVC 2017 14.1 #53

Description

@Drazuam

There's an issue with FFTextStream.cpp looking at memory before it's char buffer, which is throwing an exception on debug builds in windows. Looks like it probably wouldn't be much of an issue on a "dumber" build or system that's not checking these types of things.

Simple fix though. line 157:

while (*line.rbegin() == '\r')

needs to change to:
while (line[0]!='\0' && *line.rbegin() == '\r')

This will cause the while to exit before it can check the rbegin() function, and it wont access memory wrongly.

Edit: I made this change and it solved the issue for me locally

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions