Fix assets conversion bug. Add running with docker docs - #1767
Merged
heinezen merged 2 commits intoApr 16, 2025
Conversation
DanyCppVito
marked this pull request as ready for review
April 6, 2025 12:38
DanyCppVito
force-pushed
the
issue-1766/assets_conversion_fix
branch
from
April 6, 2025 12:46
bad53df to
d8213df
Compare
TheJJ
previously requested changes
Apr 6, 2025
heinezen
requested changes
Apr 7, 2025
DanyCppVito
force-pushed
the
issue-1766/assets_conversion_fix
branch
2 times, most recently
from
April 7, 2025 17:50
204f2db to
4d1e2f9
Compare
DanyCppVito
marked this pull request as draft
April 7, 2025 18:19
DanyCppVito
force-pushed
the
issue-1766/assets_conversion_fix
branch
2 times, most recently
from
April 7, 2025 19:00
e3eb8cd to
d762c45
Compare
DanyCppVito
force-pushed
the
issue-1766/assets_conversion_fix
branch
2 times, most recently
from
April 7, 2025 19:14
d24b56a to
716c737
Compare
DanyCppVito
marked this pull request as ready for review
April 7, 2025 19:16
Contributor
Author
heinezen
requested changes
Apr 7, 2025
heinezen
left a comment
heinezen
left a comment
Member
There was a problem hiding this comment.
Found a few small things in the files.
DanyCppVito
force-pushed
the
issue-1766/assets_conversion_fix
branch
2 times, most recently
from
April 8, 2025 18:55
d3c6e97 to
ecafbd4
Compare
DanyCppVito
force-pushed
the
issue-1766/assets_conversion_fix
branch
from
April 10, 2025 20:51
ecafbd4 to
c37333d
Compare
Add new contributor into copying.md and mailmap Issue: SFTtech#1766
DanyCppVito
force-pushed
the
issue-1766/assets_conversion_fix
branch
from
April 10, 2025 20:54
c37333d to
b077440
Compare
heinezen
requested changes
Apr 10, 2025
DanyCppVito
marked this pull request as draft
April 11, 2025 19:29
DanyCppVito
force-pushed
the
issue-1766/assets_conversion_fix
branch
from
April 12, 2025 09:56
b077440 to
f5b92e3
Compare
DanyCppVito
commented
Apr 12, 2025
DanyCppVito
marked this pull request as ready for review
April 12, 2025 10:01
DanyCppVito
force-pushed
the
issue-1766/assets_conversion_fix
branch
from
April 16, 2025 19:07
f5b92e3 to
4c86e1f
Compare
DanyCppVito
force-pushed
the
issue-1766/assets_conversion_fix
branch
2 times, most recently
from
April 16, 2025 19:14
adf3f2d to
9543d90
Compare
Using Cython < 3.0.10 leads to the runtime errors on assets conversion. Cython >= 3.0.10 shall be used. Update docker build file and add chapter in documentation about running image with Docker. Issue: SFTtech#1766
heinezen
force-pushed
the
issue-1766/assets_conversion_fix
branch
from
April 16, 2025 22:49
9543d90 to
4cf5f6f
Compare
heinezen
approved these changes
Apr 16, 2025
heinezen
enabled auto-merge
April 16, 2025 22:50
heinezen
dismissed
TheJJ’s stale review
April 16, 2025 22:52
Everythings fixed now and I want to merge :)
Member
|
thanks for the patience and your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for bug described in: #1766
Evidence:
Running inside docker image: