Skip to content

chore: remove anonymous users and NoUserInSessionTrustedTokenFilter - #469

Merged
themaherkhalil merged 2 commits into
devfrom
chore/removed-unused-filter
Nov 4, 2026
Merged

themaherkhalil merged 2 commits into
devfrom
chore/removed-unused-filter

Conversation

@themaherkhalil

Copy link
Copy Markdown
Collaborator
  • Remove AnonymousUserFilter, NoUserInSessionTrustedTokenFilter and
    NoUserInSessionTrustedTokenListener with their web.xml entries, and
    the anonymous-users-allowed and anonymous-users-upload-data settings
  • Fold ResourceUtility.respondAllowingAnonymous into respond, which
    answers a request without a signed in user with 401
  • Drop the anonymous checks from the uploaders, session filters and user
    endpoints, and the anonymousUsers and anonymousUserUploadData config
    values

- Remove AnonymousUserFilter, NoUserInSessionTrustedTokenFilter and
  NoUserInSessionTrustedTokenListener with their web.xml entries, and
  the anonymous-users-allowed and anonymous-users-upload-data settings
- Fold ResourceUtility.respondAllowingAnonymous into respond, which
  answers a request without a signed in user with 401
- Drop the anonymous checks from the uploaders, session filters and user
  endpoints, and the anonymousUsers and anonymousUserUploadData config
  values
@themaherkhalil
themaherkhalil requested a review from a team as a code owner November 4, 2026 21:46
@snyk-io

snyk-io Bot commented Nov 4, 2026

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@themaherkhalil
themaherkhalil merged commit 8d5d642 into dev Nov 4, 2026
6 checks passed
@themaherkhalil
themaherkhalil deleted the chore/removed-unused-filter branch November 4, 2026 21:56
terryozaki-wq pushed a commit that referenced this pull request Nov 5, 2026
Brings in the removal of anonymous-user support (#469) so this branch builds
against Semoss dev after #3268.

Conflicts resolved:
- pom.xml: keep jackson3.version 3.2.3 (CVE-driven) over dev's 3.1.8; no
  unused rabbitmq.version property.
- web.xml: take dev's CAC/PIV filter blocks; the commented AnonymousUserFilter
  block is gone with the filter.
- ResourceUtility: keep the SecurityAuditEvent respond overloads; drop
  respondAllowingAnonymous and the anonymous-session 401 check.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant