Skip to content

Upper grounding strip #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vijay1707 wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Upper grounding strip #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0aa5105
Made Sure Selections and Terminals are Good for Inner Strips
AbrahamTishelman-Charny Dec 8, 2015
3470624
Successful Circuitry with FSENumber=4
AbrahamTishelman-Charny Dec 11, 2015
308c979
Ground Strips Grounded
AbrahamTishelman-Charny Dec 11, 2015
99e3af2
Changed Number of FSE strips to 80, Opens in COMSOL
AbrahamTishelman-Charny Dec 11, 2015
882b8aa
Made Domains of Physics and Materials Functions of FSENumber
AbrahamTishelman-Charny Dec 12, 2015
e73e40b
Attempting to Create Upper Gound Strip
AbrahamTishelman-Charny Feb 22, 2016
045dafa
Upper Grounding Strip Initial Attempt
AbrahamTishelman-Charny Feb 24, 2016
c90f2dc
Increased Height of Ground Strips 2 and 3, Added Upper Grounding Strip
AbrahamTishelman-Charny Feb 24, 2016
56f477f
Upper Grounding Strip Seems Successfully Created
AbrahamTishelman-Charny Feb 24, 2016
99aceab
Changed Upper Grounding Strip Width
AbrahamTishelman-Charny Feb 27, 2016
0e42caf
Upper Grounding Strip Length Shortened, Domains for 60 Strip
AbrahamTishelman-Charny Mar 2, 2016
ec9ab12
Created New .java File for Creating Upper Ground Strips With Gaps
AbrahamTishelman-Charny Mar 3, 2016
4737bfb
Saving This as a Checkpoint, Next Step Move UpperStrips.java to TPC.java
AbrahamTishelman-Charny Mar 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 73 additions & 62 deletions src/TPC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
import com.comsol.model.*;
import com.comsol.model.util.*;

public class TPC {
// private static final String GroundStrip = null;

public class TPC {

public Model model;

public double TPCRadius = 800; // mm? Need to verify!
public double electrodeThickness = 1;
public double TPCRadius = 800; // in mm
public double electrodeThickness = 1;
public double TPCLength(){
return (FSELength + FSEzSpacing) * (FSENumber)+2*(FSEzSpacing+FSELength/2)-FSEzSpacing;
}
public double FSEOuterRadius(){
return TPCRadius + 2*FSEThickness + FSErSpacing;
}
// FSE is strips.
public int FSENumber = 80; // Number of strips, 80, changed to 4 to load faster
// FSE is strips (Field Shaping Elements).
public int FSENumber = 4; // Number of strips on both inner and outer, total strip number=2*(FSENumber+FSENumber-1)
public double FSELength = 9.0; // Strip length, 9.0 (mm)
public double FSEzSpacing = 1.0; // Strip spacing in z, 1 (mm)
public double FSEThickness = .035; // Strip thickness,
Expand All @@ -31,6 +31,7 @@ public double FSEOuterRadius(){
public double cageEndSpacing = 300; // second cage parameter
public double cageSideSpacing = 150; // third cage parameter
public double innerTPCradius = beampiperadius+wallwidth+insulationwidth+2*groundstripwidth; // radius before inner conductive strips
public double UpperGroundStripThickness = TPCRadius+2*FSEThickness+FSErSpacing+insulationwidth+groundstripwidth-(beampiperadius+groundstripwidth+wallwidth)-2*insulationwidth;

public double Resistance = 1000000;
public double Conductivity = .000004;
Expand All @@ -52,7 +53,7 @@ public TPC(){
this.makeTerminals();
this.makeCircuit();
this.setMaterials();
this.makeDataSet();
//this.makeDataSet();
this.makeSolver();
this.model.mesh().create("mesh1", "geom");

Expand All @@ -67,17 +68,18 @@ public void makeGeometry(){

this.addRect("anodeRect",innerTPCradius,-electrodeThickness,TPCRadius-innerTPCradius+2*FSEThickness+FSErSpacing,electrodeThickness);
this.addRect("cathodeRect",innerTPCradius,TPCLength(),TPCRadius-innerTPCradius+2*FSEThickness+FSErSpacing,electrodeThickness);
//this.addRect("UpperGroundStrip", beampiperadius+groundstripwidth+wallwidth+insulationwidth, -electrodeThickness+TPCLength()+2*electrodeThickness+insulationwidth, UpperGroundStripThickness, groundstripwidth);

this.addRect("BeamPipe",0 ,-electrodeThickness,beampiperadius , TPCLength()+2*electrodeThickness);
this.addRect("GroundStrip1",beampiperadius ,-electrodeThickness,groundstripwidth , TPCLength()+2*electrodeThickness);
this.addRect("InnerWall",beampiperadius+groundstripwidth ,-electrodeThickness,wallwidth ,TPCLength()+2*electrodeThickness );
this.addRect("GroundStrip2",beampiperadius+groundstripwidth+wallwidth ,-electrodeThickness,groundstripwidth ,TPCLength()+2*electrodeThickness );
this.addRect("GroundStrip2",beampiperadius+groundstripwidth+wallwidth ,-electrodeThickness,groundstripwidth ,TPCLength()+2*electrodeThickness+insulationwidth);
this.addRect("InnerInsulator",beampiperadius+2*groundstripwidth+wallwidth ,-electrodeThickness,insulationwidth ,TPCLength()+2*electrodeThickness );
this.addRect("OuterInsulator",TPCRadius+2*FSEThickness+FSErSpacing ,-electrodeThickness, insulationwidth, TPCLength()+2*electrodeThickness);
this.addRect("GroundStrip3",TPCRadius+2*FSEThickness+FSErSpacing+insulationwidth ,-electrodeThickness ,groundstripwidth ,TPCLength()+2*electrodeThickness );
this.addRect("GroundStrip3",TPCRadius+2*FSEThickness+FSErSpacing+insulationwidth ,-electrodeThickness ,groundstripwidth ,TPCLength()+2*electrodeThickness+insulationwidth);
this.addRect("OuterWall",TPCRadius+2*FSEThickness+groundstripwidth+FSErSpacing+insulationwidth,-electrodeThickness,wallwidth, TPCLength()+2*electrodeThickness);
this.addRect("GroundStrip4",TPCRadius+2*FSEThickness+groundstripwidth+FSErSpacing+insulationwidth+wallwidth ,-electrodeThickness ,groundstripwidth , TPCLength()+2*electrodeThickness);
this.addFSEs();
this.addGroundStrips();

//double cagez =-electrodeThickness-cageEndSpacing;
//double cagew = FSEOuterRadius()+cageSideSpacing;
Expand All @@ -95,15 +97,15 @@ public void addRect(String name, double r, double z, double t, double h){
this.model.geom("geom").feature(name).set("pos",pos);
this.model.geom("geom").feature(name).set("size",size);
}
public void addFSEs(){}// THIS METHOD DOSES NOT FUNCITON AND MUST BE OVERRIDDEN
public void makeFSEArray(double offset,String[] inputs,int size){
this.model.geom("geom").feature().create("FSEArray","Array");
this.model.geom("geom").feature("FSEArray").selection("input").set(inputs);
this.model.geom("geom").feature("FSEArray").setIndex("displ","0",0);
this.model.geom("geom").feature("FSEArray").setIndex("displ",offset,1);
this.model.geom("geom").feature("FSEArray").setIndex("fullsize","1",0);
this.model.geom("geom").feature("FSEArray").setIndex("fullsize",size+"",1);
}
public void addGroundStrips(){}// THIS METHOD DOSES NOT FUNCITON AND MUST BE OVERRIDDEN
//public void makeFSEArray(double offset,String[] inputs,int size){
//this.model.geom("geom").feature().create("FSEArray","Array");
//this.model.geom("geom").feature("FSEArray").selection("input").set(inputs);
//this.model.geom("geom").feature("FSEArray").setIndex("displ","0",0);
//this.model.geom("geom").feature("FSEArray").setIndex("displ",offset,1);
//this.model.geom("geom").feature("FSEArray").setIndex("fullsize","1",0);
//this.model.geom("geom").feature("FSEArray").setIndex("fullsize",size+"",1);
//}
public void addCircle(String name, double radius, double center){
this.model.geom("geom").feature().create(name,"Circle");
this.model.geom("geom").feature(name).set("r",radius);
Expand All @@ -113,16 +115,17 @@ public void addCircle(String name, double radius, double center){
public void makeSelections(){
this.makeAnodeSelection();
this.makeCathodeSelection();
//this.makeGroundStripSelection("groundstripone",beampiperadius);
//this.makeGroundStripSelection("groundstriptwo",beampiperadius+FSEThickness+wallwidth);
//this.makeGroundStripSelection("groundstripthree",TPCRadius+2*FSEThickness+FSErSpacing+insulationwidth);
//this.makeGroundStripSelection("groundstripfour",TPCRadius+3*FSEThickness+FSErSpacing+insulationwidth+wallwidth);
//this.makeUpperGroundStripSelection("uppergroundstrip");
this.makeGroundStripSelection("groundstripone",beampiperadius);
this.makeGroundStripSelection("groundstriptwo",beampiperadius+groundstripwidth+wallwidth);
this.makeGroundStripSelection("groundstripthree",TPCRadius+2*FSEThickness+FSErSpacing+insulationwidth);
this.makeGroundStripSelection("groundstripfour",TPCRadius+2*FSEThickness+groundstripwidth+FSErSpacing+insulationwidth+wallwidth);
//this.makeInsulatorSelection();
for(int i = 0; i < FSENumber; i++){
this.makeFSESelection(i);
//for(int i = 0; i < FSENumber; i++){
// this.makeFSESelection(i);
}
//this.makeCageSelection();
}
//}
//public void makeGroundStripOne() { //commented out unnecessary insulator selection since we are not connecting terminals to it
// this.model.selection().create("insulatorSelection","Box");
// this.model.selection("insulatorSelection").set("condition", "inside");
Expand Down Expand Up @@ -162,10 +165,14 @@ public void makeBoxSelection(String name, double rmin, double zmin, double rmax,
this.model.selection(name).set("xmax",rmax);
this.model.selection(name).set("ymax",zmax);
}
//public void makeGroundStripSelection(String name, double radius){
//this.makeBoxSelection(name,radius-FSErSpacing/4,-electrodeThickness-FSEzSpacing/4, radius+FSEThickness+FSErSpacing/4,TPCRadius+2*electrodeThickness+FSEzSpacing/4);
public void makeGroundStripSelection(String name, double radius){
this.makeBoxSelection(name,radius-FSErSpacing/4,-electrodeThickness-FSEzSpacing/4, radius+groundstripwidth+FSErSpacing/4,TPCRadius+2*electrodeThickness+FSEzSpacing/4+insulationwidth);
}
//public void makeUpperGroundStripSelection(String uppername){
// this.makeBoxSelection(uppername, beampiperadius+groundstripwidth+wallwidth-FSErSpacing/4+insulationwidth, -electrodeThickness+TPCLength()+2*electrodeThickness-FSErSpacing/4+insulationwidth, beampiperadius+groundstripwidth+wallwidth+UpperGroundStripThickness+FSErSpacing/4-insulationwidth, -electrodeThickness+TPCLength()+2*electrodeThickness+groundstripwidth+FSErSpacing/4+insulationwidth);
//}


//public void makeCageSelection(){
//this.model.selection().create("cageVolumeSelection", "Explicit");
//this.model.selection("cageVolumeSelection").set(new int[]{2});
Expand All @@ -175,14 +182,14 @@ public void makeBoxSelection(String name, double rmin, double zmin, double rmax,

public void makeTerminals(){
this.model.physics().create("current", "ConductiveMedia", "geom");
this.model.physics("current").selection().set(new int[] {1,2,4,6,8,328,330}); // Domain Selection of electric current physics
this.model.physics("current").selection().set(new int[] {1,2,4,6,9,15,17}); //used to be {1,2,4,6,8,2*FSENumber+10,2*FSENumber+12}; Domain Selection of electric current physics
this.makeAnodeTerminal();
for(int i =0; i < FSENumber; i++){
makeFSETerminal(i);
//makeInnerFSE(i);
makeFSETerminal(i);
makeInnerFSE(i);
}
this.makeCathodeTerminal();
//this.makeGroundStripTerminal();
this.makeGroundStripTerminal();
}
public void makeAnodeTerminal(){
this.model.physics("current").feature().create("anodeTerminal", "Ground",1);
Expand All @@ -202,25 +209,28 @@ public void makeInnerFSE(int actualNumber){
this.model.physics("current").feature(terminal).selection().named(selection);
this.model.physics("current").feature(terminal).set("TerminalType",1,"Circuit");
}
@SuppressWarnings("deprecation")
public void makeFSETerminal(int actualNumber){
String terminal = "FSE"+actualNumber+"Terminal";
String selection = "FSE"+actualNumber+"Selection";
this.model.physics("current").feature().create(terminal,"Terminal");
this.model.physics("current").feature(terminal).selection().named(selection);
this.model.physics("current").feature(terminal).set("TerminalType",1,"Circuit");
}
//public void makeGroundStripTerminal(){
public void makeGroundStripTerminal(){
//this.model.physics("current").feature().create("cageTerminal", "Ground", 1);//Here is the line where the connection between the faraday cage and anode terminal
//this.model.physics("current").feature("cageTerminal").selection().named("cageEdgeSelecction");
//this.model.physics("current").feature().create("GroundStripTerminalone", "Ground", 1);
//this.model.physics("current").feature("GroundStripTerminalone").selection().named("groundstripone");
//this.model.physics("current").feature().create("GroundStripTerminaltwo", "Ground", 1);
//this.model.physics("current").feature("GroundStripTerminaltwo").selection().named("groundstriptwo");
//this.model.physics("current").feature().create("GroundStripTerminalthree", "Ground", 1);
//this.model.physics("current").feature("GroundStripTerminalthree").selection().named("groundstripthree");
//this.model.physics("current").feature().create("GroundStripTerminalfour", "Ground", 1);
//this.model.physics("current").feature("GroundStripTerminalfour").selection().named("groundstripfour");
//}
this.model.physics("current").feature().create("GroundStripTerminalone", "Ground", 1);
this.model.physics("current").feature("GroundStripTerminalone").selection().named("groundstripone");
this.model.physics("current").feature().create("GroundStripTerminaltwo", "Ground", 1);
this.model.physics("current").feature("GroundStripTerminaltwo").selection().named("groundstriptwo");
this.model.physics("current").feature().create("GroundStripTerminalthree", "Ground", 1);
this.model.physics("current").feature("GroundStripTerminalthree").selection().named("groundstripthree");
this.model.physics("current").feature().create("GroundStripTerminalfour", "Ground", 1);
this.model.physics("current").feature("GroundStripTerminalfour").selection().named("groundstripfour");
this.model.physics("current").feature().create("GroundStripUpper","Ground",1);
this.model.physics("current").feature("GroundStripUpper").selection().named("uppergroundstrip");
}

public void makeCircuit(){
this.model.physics().create("cir", "Circuit", "geom");
Expand All @@ -229,9 +239,9 @@ public void makeCircuit(){
this.connectCathode();
for(int i = 1; i < FSENumber; i++){
this.addResistor("Resistor"+i,i+"",i+1+"",Resistance+"[\u03a9]");
this.addItoU("ItoU"+i,i+1+"","G",i+1);
//this.addResistor("ResistorTwo"+i,"inner"+i, "inner"+(i+1), Resistance+"[\u03a9]");
//this.addItoU("ItoUTwo"+i,"inner"+(i+1),"G",2*i+2);
this.addItoU("ItoU"+i,i+1+"","G",2*i+1);
this.addResistor("InnerResistor"+i,"inner"+i, "inner"+(i+1), Resistance+"[\u03a9]");
this.addItoU("InnerItoU"+i,"inner"+(i+1),"G",2*i+2);
}
this.connectVoltageSource();
}
Expand All @@ -242,19 +252,19 @@ public void connectAnode(){
this.addItoU("ItoU0","0","G",1);
this.addResistor("Resistor0","1","G",Resistance+"[\u03a9]");

//this.addResistor("zeroResistor1inner","inner0","1","0[\u03a9]"); // attempt here to connect inner FSE's to anode
//this.addItoU("ItoU0inner","inner0","G",2); // not sure if this works
//this.addResistor("InnerFSEtoAnode","inner"+1,"G",Resistance+"[\u03a9]"); // same may have to be done for cathode
this.addResistor("zeroResistor1inner","inner0","inner1","0[\u03a9]"); // attempt here to connect inner FSE's to anode
this.addItoU("ItoU0inner","inner0","G",2); // not sure if this works
this.addResistor("InnerFSEtoAnode","inner"+1,"G",Resistance+"[\u03a9]"); // same may have to be done for cathode

}
public void connectCathode(){
this.addResistor("zeroResistor2outer","C1","C2","0[\u03a9]");
this.addItoU("ItoUC","C1","G",FSENumber+1);
this.addItoU("ItoUC","C1","G",2*FSENumber+1); //2*FSENumber+2*(FSENumber-1)-1 or 2*FSENumber+1
this.addResistor("Resistor"+FSENumber,FSENumber+"","C2",Resistance+"[\u03a9]");

//this.addResistor("zeroResistor2inner","C1","C2","0[\u03a9]");
//this.addItoU("ItoUCinner","C1","G",2*FSENumber);
//this.addResistor("InnerFSEtoCathode","inner"+FSENumber,"C2",Resistance+"[\u03a9]");
//this.addItoU("ItoUCinner","C1","G",2*FSENumber+1); if doesn't work add innerC1 to G here
this.addResistor("InnerFSEtoCathode","inner"+FSENumber,"C2",Resistance+"[\u03a9]");
}
@SuppressWarnings("deprecation")
public void addResistor(String name, String node1, String node2, String value){
Expand All @@ -280,7 +290,7 @@ public void connectVoltageSource(){

public void setMaterials(){
this.makeCopper(); // Makes all domains copper.
this.makeAir(new int[] {1,2,4,6,8,328,330}); // Changes chosen domains from copper to air.
this.makeAir(new int[] {1,2,4,6,9,15,17}); //4 strips: {1,2,4,6,9,15,17}. 60 strips: {1,2,4,6,9,249,251} old: {1,2,4,6,8,2*FSENumber+10,2*FSENumber+12} Changes chosen domains from copper to air.
}

@SuppressWarnings("deprecation")
Expand Down Expand Up @@ -395,21 +405,22 @@ public void makeAir(int[] regions){
this.model.material("mat2").selection().set(regions);
}

public void export(String file){
this.makeDataSet();
//public void export(String file){
// this.makeDataSet();

}
public void makeDataSet(){
this.model.result().dataset().create("cpt1", "CutPoint2D");
this.model.result().dataset("cpt1").set("method", "grid");
this.model.result().dataset("cpt1").set("gridx", "range(0,1,359)");
this.model.result().dataset("cpt1").set("gridy", "range(0,1,"+this.TPCLength()+")");
}
//}
//public void makeDataSet(){
// this.model.result().dataset().create("cpt1", "CutPoint2D");
// this.model.result().dataset("cpt1").set("method", "grid");
// this.model.result().dataset("cpt1").set("gridx", "range(0,1,359)");
// this.model.result().dataset("cpt1").set("gridy", "range(0,1,"+this.TPCLength()+")");
//}

public void makeSolver(){
this.model.study().create("study");
this.model.study("study").feature().create("solver", "Stationary");
this.model.study("study").feature("solver").activate("current", true);
this.model.study("study").feature("solver").activate("cir", true);
}
}
}
//}
2 changes: 1 addition & 1 deletion src/TPCMirror.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void addFSEs(){
this.addRect("FSE3Rect",r3,z3,FSEThickness,FSELength);
this.addRect("FSE2Rect",r2,z2,FSEThickness,FSELength);
this.addRect("FSE4Rect",r4,z4,FSEThickness,FSELength);
this.makeFSEArray(2*offsetz(),new String[]{"FSE1Rect","FSE2Rect","FSE3Rect","FSE4Rect"},(FSENumber-1)/2);
//this.makeFSEArray(2*offsetz(),new String[]{"FSE1Rect","FSE2Rect","FSE3Rect","FSE4Rect"},(FSENumber-1)/2);
this.addRect("FSE"+FSENumber+"Rect", r1,z1+offsetz()*(FSENumber-1),FSEThickness,FSELength);
this.addRect("InnerFSE"+FSENumber+"Rect", r4,z4+offsetz()*(FSENumber-1),FSEThickness,FSELength); // changed r1 z1 to r4 z4 in attempt to create upper strip
}
Expand Down
17 changes: 9 additions & 8 deletions src/TPCSingle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import com.comsol.model.Model;

public class TPCSingle extends TPC {
public double FSEOuterRadius(){
return TPCRadius + FSEThickness;
public double TPCLength(){
return (FSELength + FSEzSpacing) * (FSENumber + 1)/2;
}


Expand All @@ -14,15 +14,16 @@ public static Model run(){
return new TPCSingle().model;
}

public void addFSEs(){
double z1 = FSEzSpacing+FSELength/2;
double r1 = TPCRadius;
public void addFSEs(){ //Add ground strips
//Create first upper grounding strip
double z1 = FSEzSpacing+FSELength/2; // z1=-electrodeThickness+TPCLength()+2*electrodeThickness+insulationwidth
double r1 = TPCRadius; // r1=beampiperadius+groundstripwidth+wallwidth+insulationwidth

this.addRect("FSE1Rect",r1,z1,FSEThickness,FSELength);
this.makeFSEArray(offsetz(),new String[]{"FSE1Rect"},FSENumber);
this.addRect("FSE1Rect",r1,z1,FSEThickness,FSELength); //Ground Strip Rectangle
// this.makeFSEArray(offsetz(),new String[]{"FSE1Rect"},FSENumber); //Array of Ground strip rectangles
}

public void makeFSESelection(int actualNumber){
public void makeFSESelection(int actualNumber){ //make ground strips grounded.
String name = "FSE"+actualNumber+"Selection";

double rmin = TPCRadius - FSErSpacing/4;
Expand Down
20 changes: 20 additions & 0 deletions src/UpperStrips.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import com.comsol.model.Model;

public class UpperStrips extends TPC {

public static Model run(){
return new TPCSingle().model;
}

public void addGroundStrips(){
double z1 = -electrodeThickness+TPCLength()+2*electrodeThickness+insulationwidth; //z position of first strip
double r1 = beampiperadius+groundstripwidth+wallwidth+insulationwidth; //r position of first strip

this.addRect("TopGroundStrip",r1,z1,FSELength,groundstripwidth); //Create First Ground Strip
// this.makeFSEArray(offsetz(),new String[]{"FSE1Rect"},FSENumber); //Array of Ground strip rectangles
}

//Need to add method here to ground all strips


}