Skip to content

Restructure List of "features/observations" in analysis workflow builder #70

Closed

Description

@thahmann

Feature description

Add 4 groupings to the analysis workflow builder under Blocks A and C:

  1. "Samples": include only "samples" (call them "Sample Results")

  2. "Features": include the following 4:
    a. Facilities
    b. Surface Water (this should include both what are called "Streams/Flowlines" and "Surface Water Bodies" right now)
    c. Ground Water (Aquifers)
    d. Wells

  3. "EnvironmentalVariables": leave empty for now

  4. "Model Output": leave empty for now

When "Surface Water" is selected, we need the "Feature Type" dropdown (currently called "Water Type") to include the following (merging the menus from Surface Water Bodies and Streams/Flowlines) :

  • Surface Water Bodies (Selectable; all the child options should be selectable as well)
    • Lake / Pond
    • Swamp / Marsh
    • Reservoir
  • Streams and Flowlines (Selectable, all the child options should be selectable as well)
    • Stream / River
    • Artificial Path
    • Canal / Ditch
    • Connector
    • Pipeline

This change is more of a UI change, rather than SPARQL Engine-related. Make sure to check the blast radius and whether we are making changes in the engine.

What analysis question would this let you answer?

No response

Relevant documentation or ontologies (optional)

No response

What should be the desired behavior?

see main description above

Activity

  1. dkedrowski commented on Oct 16, 2026

    @dkedrowski

    These are the FTYPE values from the NHDPlus documentation:

    • Surface Water Bodies (NHDWaterbody)

      • Lake/Pond (in our data as LakePond)
      • Reservoir (in our data)
      • Swamp/Marsh (in our data as SwampMarsh)
      • Inundation Area (in our data; however, in the documentation, this is supposed to be used with the NHDArea class)
      • Estuary
      • Ice Mass
      • Playa
    • Streams and Flowlines (NHDFlowline)

      • Artificial Path (in our data as ArtificialPath)
      • Canal/Ditch (in our data as CanalDitch)
      • Connector (in our data)
      • Pipeline (in our data)
      • Stream/River (in our data as StreamRiver)
      • Drainageway
      • Underground Conduit
      • Coastline (we purposefully do not triplify any of these)
  2. prayaslashkari commented on Oct 26, 2026

    @prayaslashkari
    Collaborator

    Proposed hierarchy

    This is a UI-only change: no files under src/engine/ change, and queries, saved questions, and question text stay as they are.

    @thahmann @dkedrowski

    Type menu (Blocks A and C)

    Samples
      Sample Results
    Features
      Facilities
      Surface Water
      Ground Water (Aquifers)
      Wells
    Environmental Variables
      Coming soon (disabled)
    Model Output
      Coming soon (disabled)
    
    Image

    @thahmann @dkedrowski

    Feature Type (shown when Surface Water is picked, replaces "Water Type")

    [ ] Surface Water Bodies
        [ ] Lake / Pond
        [ ] Swamp / Marsh
        [ ] Reservoir
        [-] Inundation Area (not available yet)
        [-] Estuary (not available yet)
        [-] Ice Mass (not available yet)
        [-] Playa (not available yet)
    [ ] Streams and Flowlines
        [ ] Stream / River
        [ ] Artificial Path
        [ ] Canal / Ditch
        [ ] Connector
        [ ] Pipeline
        [-] Drainageway (not available yet)
        [-] Underground Conduit (not available yet)
    

    The dropdown will not show counts in this issue (see Follow-ups). For reference, records on hydrologykg as of 2026-10-26:

    Feature Type Records
    Lake / Pond 60,083
    Swamp / Marsh 12,015
    Reservoir 886
    Inundation Area 1
    Stream / River 353,003
    Artificial Path 69,801
    Canal / Ditch 7,821
    Connector 3,786
    Pipeline 90
    Estuary, Ice Mass, Playa, Drainageway, Underground Conduit 0

    Quick Preview

    Image Image

    @dkedrowski, can you confirm the greyed-out list?

    Implemented

    Branch feat/workflow-feature-grouping-70-0c76372e, PR to follow against development. Behavior as built:

    • One parent at a time. Ticking under the other parent clears the first and switches between water bodies and streams.
    • Default. Picking Surface Water ticks "Surface Water Bodies". Untick it to pick a single child, e.g. just Lake / Pond. Applied with nothing ticked, it runs as Surface Water Bodies and shows that chip.
    • Greyed-out options carry a "(not available yet)" tag and cannot be ticked.
    • A whole parent sends the same query as today, and old saved Streams questions load as Surface Water with "Streams and Flowlines" ticked.

    Follow-ups (separate issues)

    1. Question text and step labels. Change the generated question text and the pipeline step labels to the new names ("sample results", "ground water").
    2. Counts in dropdowns. Show counts next to Feature Type options: region-scoped when a region is applied, nationwide when none is. We should probably do the same for every other relevant dropdown, so they all behave alike:
      • Substance and Material already work this way.
      • Industry counts show nothing until a state is picked, so they need a nationwide fallback.
      • Well Source, Aquifer Type, and Feature Type have no counts yet.
      • Nationwide count query doesn't have to be called when we open any analysis question.
    3. Surface Water Bodies and Streams together. Ticking both parents in one question needs engine work, since the two are queried as separate classes. Size and query cost are being measured; findings will be posted here.
  3. dkedrowski commented on Oct 27, 2026

    @dkedrowski

    @prayaslashkari ,
    You can remove Drainageway and Underground Conduit from the flowline options. While listed in the documentation, I see no evidence of their use across the 21 NHDFlowline files that cover the conterminous US.

    @thahmann ,
    I recommend removing Inundation Area and Estuary from the water body options. Inundation Area has 1 use in 1 HUC and Estuary has only 4 uses across just 2 HUCs. That's out of ~450,000 waterbodies in the 21 NHDWaterbody files I have. What do you think?

  4. thahmann commented on Oct 27, 2026

    @thahmann
    ContributorAuthor

    I agree that removing Inundation Area and Estuary makes sense until we come across more or find a different more systematic datasource for them.

  5. added 2 commits that reference this issue on Oct 27, 2026
  6. prayaslashkari commented on Oct 28, 2026

    @prayaslashkari
    Collaborator

    This was merged on the Development.

  7. prayaslashkari commented on Oct 30, 2026

    @prayaslashkari
    Collaborator

    Union.- Surface Water Bodies and Streams & Flowlines when Surface Water Bodies is selected.

    cc @thahmann

  8. prayaslashkari commented on Nov 17, 2026

    @prayaslashkari
    Collaborator

    This was generated by AI during triage.

    Closing as completed. The grouped Type menu and the single Surface Water entry with Feature Type shipped in #83 (merged to development 2026-10-28; reaches production with #92). Drainageway, Underground Conduit, Inundation Area and Estuary were left out, as agreed above.

    The three follow-ups from the 2026-10-26 comment are now their own issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions