You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Restructure List of "features/observations" in analysis workflow builder #70
Add 4 groupings to the analysis workflow builder under Blocks A and C:
"Samples": include only "samples" (call them "Sample Results")
"Features": include the following 4:
a. Facilities
b. Surface Water (this should include both what are called "Streams/Flowlines" and "Surface Water Bodies" right now)
c. Ground Water (Aquifers)
d. Wells
"EnvironmentalVariables": leave empty for now
"Model Output": leave empty for now
When "Surface Water" is selected, we need the "Feature Type" dropdown (currently called "Water Type") to include the following (merging the menus from Surface Water Bodies and Streams/Flowlines) :
Surface Water Bodies (Selectable; all the child options should be selectable as well)
Lake / Pond
Swamp / Marsh
Reservoir
Streams and Flowlines (Selectable, all the child options should be selectable as well)
Stream / River
Artificial Path
Canal / Ditch
Connector
Pipeline
This change is more of a UI change, rather than SPARQL Engine-related. Make sure to check the blast radius and whether we are making changes in the engine.
One parent at a time. Ticking under the other parent clears the first and switches between water bodies and streams.
Default. Picking Surface Water ticks "Surface Water Bodies". Untick it to pick a single child, e.g. just Lake / Pond. Applied with nothing ticked, it runs as Surface Water Bodies and shows that chip.
Greyed-out options carry a "(not available yet)" tag and cannot be ticked.
A whole parent sends the same query as today, and old saved Streams questions load as Surface Water with "Streams and Flowlines" ticked.
Follow-ups (separate issues)
Question text and step labels. Change the generated question text and the pipeline step labels to the new names ("sample results", "ground water").
Counts in dropdowns. Show counts next to Feature Type options: region-scoped when a region is applied, nationwide when none is. We should probably do the same for every other relevant dropdown, so they all behave alike:
Substance and Material already work this way.
Industry counts show nothing until a state is picked, so they need a nationwide fallback.
Well Source, Aquifer Type, and Feature Type have no counts yet.
Nationwide count query doesn't have to be called when we open any analysis question.
Surface Water Bodies and Streams together. Ticking both parents in one question needs engine work, since the two are queried as separate classes. Size and query cost are being measured; findings will be posted here.
@prayaslashkari ,
You can remove Drainageway and Underground Conduit from the flowline options. While listed in the documentation, I see no evidence of their use across the 21 NHDFlowline files that cover the conterminous US.
@thahmann ,
I recommend removing Inundation Area and Estuary from the water body options. Inundation Area has 1 use in 1 HUC and Estuary has only 4 uses across just 2 HUCs. That's out of ~450,000 waterbodies in the 21 NHDWaterbody files I have. What do you think?
Closing as completed. The grouped Type menu and the single Surface Water entry with Feature Type shipped in #83 (merged to development 2026-10-28; reaches production with #92). Drainageway, Underground Conduit, Inundation Area and Estuary were left out, as agreed above.
The three follow-ups from the 2026-10-26 comment are now their own issues:
Activity
dkedrowski commentedon Oct 16, 2026
These are the FTYPE values from the NHDPlus documentation:
Surface Water Bodies (NHDWaterbody)
Streams and Flowlines (NHDFlowline)
prayaslashkari commentedon Oct 26, 2026
Proposed hierarchy
This is a UI-only change: no files under
src/engine/change, and queries, saved questions, and question text stay as they are.@thahmann @dkedrowski
Type menu (Blocks A and C)
@thahmann @dkedrowski
Feature Type (shown when Surface Water is picked, replaces "Water Type")
The dropdown will not show counts in this issue (see Follow-ups). For reference, records on
hydrologykgas of 2026-10-26:Quick Preview
@dkedrowski, can you confirm the greyed-out list?
Implemented
Branch
feat/workflow-feature-grouping-70-0c76372e, PR to follow againstdevelopment. Behavior as built:Follow-ups (separate issues)
dkedrowski commentedon Oct 27, 2026
@prayaslashkari ,
You can remove Drainageway and Underground Conduit from the flowline options. While listed in the documentation, I see no evidence of their use across the 21 NHDFlowline files that cover the conterminous US.
@thahmann ,
I recommend removing Inundation Area and Estuary from the water body options. Inundation Area has 1 use in 1 HUC and Estuary has only 4 uses across just 2 HUCs. That's out of ~450,000 waterbodies in the 21 NHDWaterbody files I have. What do you think?
thahmann commentedon Oct 27, 2026
I agree that removing Inundation Area and Estuary makes sense until we come across more or find a different more systematic datasource for them.
feat(query-editor): drop the greyed-out Feature Type options (#70)
Merge pull request #83 from SAWGraph/feat/workflow-feature-grouping-7…
prayaslashkari commentedon Oct 28, 2026
This was merged on the Development.
prayaslashkari commentedon Oct 30, 2026
Union.- Surface Water Bodies and Streams & Flowlines when Surface Water Bodies is selected.
cc @thahmann
prayaslashkari commentedon Nov 17, 2026
Closing as completed. The grouped Type menu and the single Surface Water entry with Feature Type shipped in #83 (merged to
development2026-10-28; reaches production with #92). Drainageway, Underground Conduit, Inundation Area and Estuary were left out, as agreed above.The three follow-ups from the 2026-10-26 comment are now their own issues:
ready-for-agent)needs-triage)ready-for-human)