Skip to content

fix: dispatching QuoteDetailsReloadQueryEvent from QuoteLinksComponent#21196

Merged
suprishi merged 14 commits intodevelopfrom
CXSPA-11826-bugfix
Mar 10, 2026
Merged

fix: dispatching QuoteDetailsReloadQueryEvent from QuoteLinksComponent#21196
suprishi merged 14 commits intodevelopfrom
CXSPA-11826-bugfix

Conversation

@suprishi
Copy link
Copy Markdown
Member

@suprishi suprishi commented Feb 26, 2026

Fix for CXSPA-11826

@suprishi suprishi requested review from a team as code owners February 26, 2026 09:54
@github-actions github-actions Bot marked this pull request as draft February 26, 2026 09:54
@suprishi suprishi marked this pull request as ready for review February 26, 2026 11:22
@cypress
Copy link
Copy Markdown

cypress Bot commented Feb 26, 2026 •
edited
Loading

spartacus    Run #52178

Run Properties:  status check passed Passed #52178  •  git commit 9a6f19c3bf ℹ️: Merge 60560a9a60881a52a208b82c5d97675759b843ae into 1e0a1b81bf7e7b802b0620bad390...
Project spartacus
Branch Review CXSPA-11826-bugfix
Run status status check passed Passed #52178
Run duration 11m 31s
Commit git commit 9a6f19c3bf ℹ️: Merge 60560a9a60881a52a208b82c5d97675759b843ae into 1e0a1b81bf7e7b802b0620bad390...
Committer Saptarshi Bose
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 101
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@github-actions github-actions Bot marked this pull request as draft February 27, 2026 05:54
@suprishi suprishi marked this pull request as ready for review February 27, 2026 06:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026

E2E Tests Failed ❌

📸 Download Screenshots

Commit: 0b1031a8a68c62205e0b1c4c3faa78eb33b3a005

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft February 27, 2026 06:44
@suprishi suprishi marked this pull request as ready for review February 27, 2026 06:57
@github-actions github-actions Bot marked this pull request as draft March 3, 2026 04:19
@suprishi suprishi marked this pull request as ready for review March 3, 2026 05:09
@zhangxr-online
Copy link
Copy Markdown

zhangxr-online commented Mar 4, 2026

Suggestion: Ensure that the PR includes unit tests for the event dispatch behavior of ngOnInit.

@github-actions github-actions Bot marked this pull request as draft March 4, 2026 05:20
@suprishi suprishi marked this pull request as ready for review March 4, 2026 08:36
@github-actions github-actions Bot marked this pull request as draft March 6, 2026 14:04
@suprishi suprishi marked this pull request as ready for review March 9, 2026 05:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 9, 2026

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft March 9, 2026 06:18
@suprishi suprishi marked this pull request as ready for review March 9, 2026 06:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 9, 2026

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft March 9, 2026 11:57
@suprishi suprishi marked this pull request as ready for review March 9, 2026 12:17
@github-actions github-actions Bot marked this pull request as draft March 10, 2026 05:49
@suprishi suprishi marked this pull request as ready for review March 10, 2026 06:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft March 10, 2026 09:33
@suprishi suprishi marked this pull request as ready for review March 10, 2026 10:09
@github-actions github-actions Bot marked this pull request as draft March 10, 2026 12:05
@suprishi suprishi marked this pull request as ready for review March 10, 2026 14:15
@suprishi suprishi merged commit 426e582 into develop Mar 10, 2026
38 checks passed
@suprishi suprishi deleted the CXSPA-11826-bugfix branch March 10, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmch91 rmch91 rmch91 approved these changes

@vigneshkrish8691 vigneshkrish8691 vigneshkrish8691 left review comments

+1 more reviewer

@zhangxr-online zhangxr-online zhangxr-online approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suprishi @zhangxr-online @vigneshkrish8691 @rmch91