Skip to content

Add x-override-allowed to indicate annotations can be overridden by customer / merge - #109

Draft
Fannon wants to merge 7 commits into
mainfrom
x-override-allowed
Draft

Add x-override-allowed to indicate annotations can be overridden by customer / merge#109
Fannon wants to merge 7 commits into
mainfrom
x-override-allowed

Conversation

@Fannon

@Fannon Fannon commented Aug 13, 2025

Copy link
Copy Markdown
Member

Just a draft / WIP:

Requirement has come up to annotate on meta level which annotations make sense to override when CSN Interop files are merged. This can happen e.g. when a customer creates some override extensions, most notably overriding a UI facing label for a property or entity.

@stewsk will find out which annotations are affected.

@maiargu - we'll have to add this to the spec-toolkit as allowed and defined x- attribute and maybe also indicating this on the generated documentation (? not sure.). We also need to ensure that the spec extensions are exported as JSON Schema in a way that our stakeholders can retrieve them, e.g. as NPM dependency or HTTP download.

Fannon added 6 commits August 5, 2025 09:34
Signed-off-by: Simon Heimler <simon.heimler@sap.com>
…orking

Signed-off-by: Simon Heimler <simon.heimler@sap.com>
Signed-off-by: Simon Heimler <simon.heimler@sap.com>
Signed-off-by: Simon Heimler <simon.heimler@sap.com>
Signed-off-by: Simon Heimler <simon.heimler@sap.com>
Signed-off-by: Simon Heimler <simon.heimler@sap.com>
@Fannon
Fannon requested review from maiargu and stewsk August 13, 2025 15:05
@Fannon Fannon self-assigned this Aug 13, 2025
@stewsk

stewsk commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

@Fannon

@stewsk will find out which annotations are affected.

??? Did I miss this point in the discussion we had?

@Fannon

Fannon commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

@Fannon

@stewsk will find out which annotations are affected.

??? Did I miss this point in the discussion we had?

@stewsk - I meant which annotations should have x-override-allowed: true assigned to them. Or is it just the EnduserText.label for now?

@frankejoe

Copy link
Copy Markdown
Contributor

@Fannon : the action item is on me to create an initial proposal of annotations.

@Fannon

Fannon commented Aug 14, 2025

Copy link
Copy Markdown
Member Author

@Fannon : the action item is on me to create an initial proposal of annotations.

Ah, sorry - i had the wrong mention. Sorry @stewsk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants