Standardize cloudfoundry provider to v1.20.0 baseline#208
Draft
maximilianbraun wants to merge 14 commits intomainfrom
Draft
Standardize cloudfoundry provider to v1.20.0 baseline#208maximilianbraun wants to merge 14 commits intomainfrom
maximilianbraun wants to merge 14 commits intomainfrom
Conversation
Initialize build submodule and update dependencies to match BTP baseline: Dependencies updated: - Go: 1.24.10 → 1.25 (toolchain go1.25.6) - k8s.io/api: v0.34.1 → v0.35.1 - k8s.io/apimachinery: v0.34.3 → v0.35.1 - k8s.io/client-go: v0.34.1 → v0.35.1 - controller-tools: v0.16.0 → v0.16.5 - All k8s indirect dependencies updated to v0.35.1 Already aligned with BTP: - crossplane-runtime: v1.20.0 - controller-runtime: v0.20.0 - e2e-framework: v0.6.0 - xp-testing: v1.9.0 Build submodule: - Initialized build submodule (was present but not initialized) - Using commit 185d22c from upbound/build Testing: - Build successful for all architectures - Unit tests passing - CRDs regenerated with controller-tools v0.16.5 Part of Phase 1 standardization (Week 3) from dependency consistency report. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Add version: "2" and remove gofmt/goimports from linters.enable. golangci-lint v2 treats gofmt and goimports as formatters, not linters. Formatting is handled separately by make fmt. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
- Upgrade golangci-lint from v2.8.0 to v2.10.0 - Upgrade Go from 1.25.0 to 1.26 (toolchain go1.26.0) - Remove 'gosimple' from linters (v2 compatibility - merged into staticcheck) - Confirm version: "2" already present in .golangci.yml Validation: - go.test.unit: all tests pass ✓ - go.lint: 54 pre-existing issues (staticcheck, goconst, gocyclo) - These are code quality issues, not configuration issues - Safe to proceed per Phase 1 standardization guidelines Part of Phase 1 standardization to BTP v1.20.0 baseline with golangci-lint v2.10.0+ compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Replace vendored build files with proper git submodule pointing to upbound/build@3b99463 for standardization. Changes: - Remove vendored build/ directory files - Add build as proper git submodule - Target commit: 3b99463 (upbound/build standard) This restores the intended git submodule architecture per Phase 1 standardization guidelines. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Update go-version from 1.23/1.24 to 1.26 across workflow files: - check-go-licenses.yaml - e2e_test.yaml - release-candidate.yaml - release.yaml - reviewable_check_diff.yaml - unit_test.yaml - upgrade-test.yaml Aligns with Phase 1 baseline (Go 1.26 + golangci-lint v2.10.0). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
…0 QF1008 remain) Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Remove embedded field names from selectors per QF1008, lowercase error strings per ST1005, consolidate duplicate imports per ST1019, and remove now-unnecessary //nolint:staticcheck directives. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
Fixes config verify failures: remove linters.presets/fast, migrate exclusions to linters.exclusions, move formatters to formatters section. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
SatabdiG
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
SatabdiG
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
SatabdiG
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades cloudfoundry provider to BTP v1.20.0 baseline (major jump from v1.17.0).
Changes
Validation
Part of Phase 1 standardization (16/17 providers).