Add OTel Span Attribute Filter - #409
Open
KarstenSchnitter wants to merge 2 commits into
Open
Conversation
Introduction of SpanAttributeCustomizer interface to allow different implementations in future. Customizers can be disabled by config in which case they are removed from the list of potential customizers. To avoid allocation of a new attributes map they can preemptively declare "no changes" on a span dataset. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Adds a new span exporter customizer to filter spann attributes by the same semantics as already available for metrics by name. The user is able to provide inclusion and exclusion lists with wildcard support. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #399
Provide filtering of OpenTelemetry span attributes by comma-separated inclusion and exclusion lists. The feature is semantically identical to the metrics filtering. The new configuration properties are:
sap.cf.integration.otel.extension.sanitizer.span.attribute.filter.include.namescomma-separated attribute names to include allowing for wildcard "*" at the endsap.cf.integration.otel.extension.sanitizer.span.attribute.filter.exclude.namescomma-separate attribute names to exclude allowing for wildcard "*" at the end with higher priority than includes