-
Notifications
You must be signed in to change notification settings - Fork 0
Restructure docling
#42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lative import from .main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures the docling package by moving it from a standalone service to a proper uv workspace package and improving the API integration. The changes simplify deployment while maintaining functionality for PDF-to-text conversion using docling.
- Restructured
doclingfromsrc/ocr/doclingto a proper uv package inpackages/ocr/docling - Updated API router to use async HTTP client and simplified environment handling
- Improved Docker configuration with dependency caching and updated volume mounting
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ocr/docling/requirements.txt | Removed old requirements file as dependencies moved to pyproject.toml |
| src/ocr/docling/README.md | Removed old README in favor of new package documentation |
| src/ocr/docling/Dockerfile | Removed old Dockerfile replaced by new package-based version |
| src/api/app/routers/docling.py | Updated to use async HTTP client and simplified environment handling |
| pyproject.toml | Added docling optional dependency and workspace source configuration |
| packages/ocr/docling/src/pyonb_docling/api.py | Cleaned up import handling removing Docker-specific workarounds |
| packages/ocr/docling/pyproject.toml | New package configuration with proper dependencies |
| packages/ocr/docling/README.md | New documentation for using the restructured package |
| packages/ocr/docling/Dockerfile | New optimized Dockerfile with dependency caching |
| docker-compose.yml | Updated service configuration for new package structure |
| README.md | Updated installation instructions and project description |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/ocr/docling/Dockerfile
Outdated
| ENV PYTHONUNBUFFERED=1 | ||
|
|
||
| COPY ./pyproject.toml . | ||
| COPY ./README . |
Copilot
AI
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The COPY command copies './README' but the actual file is 'README.md'. This will cause the Docker build to fail.
| COPY ./README . | |
| COPY ./README.md . |
Following on from #38, restructure
pyonb:src/ocr/doclingauvpackage inpackages/ocr/doclingdoclingDockerfile to cache dependenciesDATA_FOLDERfor mounting thedoclingandocr-forwarding-apidata volumespyonband running inference withdoclingtest_inference_single_file_upload_doclingandtest_inference_on_folder_doclingboth pass