Fix YouTube import by replacing eval with JSON.parse#25
Open
thatrobotdev wants to merge 1 commit intoRustyNova016:mainfrom
Open
Fix YouTube import by replacing eval with JSON.parse#25thatrobotdev wants to merge 1 commit intoRustyNova016:mainfrom
thatrobotdev wants to merge 1 commit intoRustyNova016:mainfrom
Conversation
The script is currently broken because calls to eval() are forbidden by YouTube's CSP settings. This is because eval() can execute arbitrary code, which is unnecessary with this call because we are just parsing the JSON response. So, we switch to the safer and effective JSON.parse, which fixes the issue.
thatrobotdev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The YouTube import script is currently broken because calls to
eval()are forbidden by YouTube's CSP settings. This is becauseeval()can execute arbitrary code, which is unnecessary with this call because we are just parsing the JSON response.So, this switches to the safer and effective
JSON.parse, which fixes #17.