refactor: components and improve responsiveness across UI#63
Closed
bryanlundberg wants to merge 20 commits intoRustLangES:migrate-astrofrom
bryanlundberg:experimental-drag-react
Closed
refactor: components and improve responsiveness across UI#63bryanlundberg wants to merge 20 commits intoRustLangES:migrate-astrofrom bryanlundberg:experimental-drag-react
bryanlundberg wants to merge 20 commits intoRustLangES:migrate-astrofrom
bryanlundberg:experimental-drag-react
Conversation
…ge to native HTML `<section>`
…issue in Sidebar component
…restructure content handling
…ve ReactPanelContainer functionality
…ance panel responsiveness
…erminalOutput components
…ner type handling
- Remove content.config.ts and replace with more direct content management - Update ReactMarkdownContainer to remove unnecessary elements and simplify layout - Refactor NavButtons.astro to use new meta props - Remove dynamic content loading from Hero component - Adjust Navbar and other components to support new content management approach - Add new content-manager.ts helper to potentially replace previous configuration method
Member
Contributor
|
@SergioRibera We'll keep that in mind. Perhaps a simple solution would be to switch to tabs when it reaches a certain size |
Contributor
Author
Member
|
@ArturoAtomplay They could consider the previous alternative for when the screen is very small, as it can occupy a considerable percentage of space |
Member
|
Estuve revisando el código y veo que cambiaron bastante, en lo que estoy viendo la propuesta quita la parte estática que era lo que nos interesa realmente, cargar la menor cantidad de js posible, entre otras cosas que no me agradan mucho de la contribucion por la parte de react es la micro componetización que se implementó y como muchas cosas que podrian ser css pasaron a ser js, por lo que se discutió con el equipo y decidimos continuar con la implementación de Astro actual |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
This pull request involves significant improvements to the codebase in terms of responsiveness, styling, and readability:
ReactPanelContainerfunctionality.ReactPanelContainerstyles and improved the resize handle structure for better user experience.Section.astrousage to native HTML<section>for more standardized and clear markup.noDangerouslySetInnerHtmlrule, and resolved a unique key issue in theSidebarcomponent.