[Econ] Anaerobic Digester CHP and RNG - #3140
Open
allisterakun wants to merge 6 commits into
Open
Conversation
bradenlimb
requested changes
Aug 17, 2026
bradenlimb
left a comment
Collaborator
There was a problem hiding this comment.
Calculations on the electricity to rng ratios work out for me! So we are good on that front.
However I noticed that the biophysical_aggregate value multiplied by the price_aggregate value doesn't exactly equal the line_item_by_scenario value. In the following image I get the following
495139.0225 * 0.005363327 = 2655.592727
Collaborator
Author
Collaborator
|
Hey @allisterakun - thanks for clarifying. The calculations you have are the ones we want. Let's leave as is. This is just the first variable that I've seen with this issue. I wonder if the others aren't calculating correctly or just aren't doing daily calcs. Probably something we should look into at some point |
bradenlimb
marked this pull request as ready for review
August 18, 2026 19:33
bradenlimb
self-requested a review
August 18, 2026 19:34
bradenlimb
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context
Issue(s) closed by this pull request: closes #3086
What
Why
How
Test plan
Input Changes
Output Changes
Filter