✨ Queue Rudder rewrite batches - #89
Merged
Merged
Conversation
📦 No plugin release on mergeThe plugin package, tag, and GitHub Release already exist for |
|
Ready to review this PR? Stage has broken it down into 2 individual chapters for you:
Chapters generated by Stage for commit 813480a on Jul 29, 2026 9:46pm UTC. |
Comment on lines
+113
to
119
| test('ships a public marketplace catalog and its package resources', () => { | ||
| const marketplace = JSON.parse( | ||
| readFileSync( | ||
| join(pluginRoot, '.claude-plugin', 'marketplace.json'), | ||
| 'utf8' | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Preserve structural skill metadata validation
This cleanup removes the only assertion for the Rudder skill's required identifying frontmatter, allowing CI to publish an undiscoverable or incorrectly identified skill. Retain a structural metadata check without restoring assertions against instructional prose.
Suggested change
| test('ships a public marketplace catalog and its package resources', () => { | |
| const marketplace = JSON.parse( | |
| readFileSync( | |
| join(pluginRoot, '.claude-plugin', 'marketplace.json'), | |
| 'utf8' | |
| ) | |
| ); | |
| test('ships a public marketplace catalog and its package resources', () => { | |
| const marketplace = JSON.parse( | |
| readFileSync( | |
| join(pluginRoot, '.claude-plugin', 'marketplace.json'), | |
| 'utf8' | |
| ) | |
| ); | |
| const skill = readFileSync( | |
| join(pluginRoot, 'skills', 'rudder', 'SKILL.md'), | |
| 'utf8' | |
| ); | |
| assert.match(skill, /^---\nname: rudder\n/); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a bounded batch workflow for independently authorized Rudder coverage rewrites, with main-agent ownership of questions and integration. Batches are capped at three tasks and require combined suites and coverage after joining. Removes brittle tests that asserted literal SKILL.md prose while retaining package-resource and runtime coverage.
Greptile Summary
This PR introduces a bounded concurrent workflow for authorized Rudder rewrites and removes tests coupled to literal skill instructions.
Confidence Score: 4/5
The PR appears safe to merge, with a non-blocking recommendation to retain structural validation of the packaged skill metadata.
The queued workflow includes disjoint ownership and combined-suite safeguards, while the test cleanup leaves required skill frontmatter vulnerable to undetected future regressions.
Files Needing Attention: test/plugin-package.test.ts
Important Files Changed
Sequence Diagram
sequenceDiagram participant U as User participant M as Main agent participant W as Rewrite agents U->>M: Answer one intent question M->>M: Capture answer and queue task M->>W: Dispatch up to three disjoint rewrites W-->>M: Return narrow green results M->>M: Inspect combined diff M->>M: Run related and full suites M->>M: Run coverage after greenReviews (1): Last reviewed commit: "✨ add queued Rudder rewrite workflow" | Re-trigger Greptile