Skip to content

✨ Queue Rudder rewrite batches - #89

Merged
Vivekyy merged 2 commits into
mainfrom
Vivekyy/queue-rudder-rewrites
Jul 29, 2026
Merged

✨ Queue Rudder rewrite batches#89
Vivekyy merged 2 commits into
mainfrom
Vivekyy/queue-rudder-rewrites

Conversation

@Vivekyy

@Vivekyy Vivekyy commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Adds a bounded batch workflow for independently authorized Rudder coverage rewrites, with main-agent ownership of questions and integration. Batches are capped at three tasks and require combined suites and coverage after joining. Removes brittle tests that asserted literal SKILL.md prose while retaining package-resource and runtime coverage.


Open in Stage

Greptile Summary

This PR introduces a bounded concurrent workflow for authorized Rudder rewrites and removes tests coupled to literal skill instructions.

  • Allows up to three independently owned rewrite tasks between coverage runs.
  • Keeps question interpretation, integration, combined test execution, and coverage with the main agent.
  • Removes prose assertions from the package test while retaining packaged-resource checks.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking recommendation to retain structural validation of the packaged skill metadata.

The queued workflow includes disjoint ownership and combined-suite safeguards, while the test cleanup leaves required skill frontmatter vulnerable to undetected future regressions.

Files Needing Attention: test/plugin-package.test.ts

Important Files Changed

Filename Overview
skills/rudder/SKILL.md Adds clear ownership, batching, isolation, integration, and post-join verification rules for queued rewrites.
test/plugin-package.test.ts Removes brittle prose checks but also drops the only structural assertion for required skill frontmatter.

Sequence Diagram

sequenceDiagram
    participant U as User
    participant M as Main agent
    participant W as Rewrite agents
    U->>M: Answer one intent question
    M->>M: Capture answer and queue task
    M->>W: Dispatch up to three disjoint rewrites
    W-->>M: Return narrow green results
    M->>M: Inspect combined diff
    M->>M: Run related and full suites
    M->>M: Run coverage after green
Loading

Fix All in Cursor Fix All in Conductor

Reviews (1): Last reviewed commit: "✨ add queued Rudder rewrite workflow" | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

@github-actions

Copy link
Copy Markdown

📦 No plugin release on merge

The plugin package, tag, and GitHub Release already exist for 0.1.3.
Bump package.json to release a new plugin version.

@ghost

ghost commented Jul 29, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 2 individual chapters for you:

Title
1 Define bounded batch rewrite workflow in SKILL.md
2 Remove brittle prose assertions from package tests
Open in Stage

Chapters generated by Stage for commit 813480a on Jul 29, 2026 9:46pm UTC.

Comment on lines +113 to 119
test('ships a public marketplace catalog and its package resources', () => {
const marketplace = JSON.parse(
readFileSync(
join(pluginRoot, '.claude-plugin', 'marketplace.json'),
'utf8'
)
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Preserve structural skill metadata validation

This cleanup removes the only assertion for the Rudder skill's required identifying frontmatter, allowing CI to publish an undiscoverable or incorrectly identified skill. Retain a structural metadata check without restoring assertions against instructional prose.

Suggested change
test('ships a public marketplace catalog and its package resources', () => {
const marketplace = JSON.parse(
readFileSync(
join(pluginRoot, '.claude-plugin', 'marketplace.json'),
'utf8'
)
);
test('ships a public marketplace catalog and its package resources', () => {
const marketplace = JSON.parse(
readFileSync(
join(pluginRoot, '.claude-plugin', 'marketplace.json'),
'utf8'
)
);
const skill = readFileSync(
join(pluginRoot, 'skills', 'rudder', 'SKILL.md'),
'utf8'
);
assert.match(skill, /^---\nname: rudder\n/);

Fix in Cursor Fix in Conductor

@Vivekyy
Vivekyy merged commit 99ca5e3 into main Jul 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant