FEAT: Add 'Always uncompress entire archive' option - #368
Merged
Ruben2776 merged 1 commit intoAug 7, 2026
Conversation
Introduce a new Navigation setting AlwaysUncompressEntireArchive with a toggle in the Navigation settings UI and localization entries for all languages. ArchiveExtractionService now supports fully extracting an archive when the setting is enabled (async extraction, safer error handling, and improved cleanup). NavigationService updated to detect archives, seed iterators, handle side-by-side preloading, and kick off background extraction. UI improvements: show/hide loading indicator during file/archive open (FilePicker, DragAndDrop). Added search tags/indexing, wired settings and translation viewmodels, fixed EvictingDictionary.TryAdd call signature, and added unit tests for full-extract behavior and sequential archive cleanup.
Owner
|
Looks great. Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR for this repo, let me know if you want anything changed.
Description
Introduce a new Navigation setting AlwaysUncompressEntireArchive with a toggle in the Navigation settings UI and localization entries for all languages.
ArchiveExtractionService now supports fully extracting an archive when the setting is enabled (async extraction, safer error handling, and improved cleanup).
NavigationService updated to detect archives, seed iterators, handle side-by-side preloading, and kick off background extraction.
UI improvements: show/hide loading indicator during file/archive open (FilePicker, DragAndDrop).
Added search tags/indexing, wired settings and translation viewmodels,
Fixed EvictingDictionary.TryAdd call signature (new required parameter)
Added unit tests for full-extract behavior and sequential archive cleanup.
Motivation and Context
Loading .cbz / .cbr from a network drive was very slow, with 1/2 second per page change, even over wired 1gbit. This optional (defaulted off) change will uncompress the entire archive during loading, so you can page through with no lag.
How Has This Been Tested?
Yes, all tests pass and it was manually verified in the UI. New unit tests have been added to cover.
Screenshots (if appropriate):
Types of changes
Checklist: