Skip to content

[Fix] Automation schedules revert after edits during save #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roomote-roomote wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Fix] Automation schedules revert after edits during save #3701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/docs/automation-configuration.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ automations on or off, and apply the selected set. Skipping the review does not
enable anything. Recommendations are a starting point: use the **Automations**
page to change schedules, destinations, workspace targets, prompts, or models.

For Security Auditor, Code Quality Auditor, CI Failure Triage, Triage Issues,
and Merge announcer, the schedule or enable switch pauses while its settings
are saving. If a save fails, your draft remains available to edit and retry.

## Pull request automations

These automations react to pull requests, issues, and repository state.
Expand Down
3 changes: 3 additions & 0 deletions apps/web/src/components/settings/SettingSummaryRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@ export function SettingSummaryRow({
label,
value,
onEdit,
disabled = false,
actionLabel = 'Edit',
action,
}: {
icon: LucideIcon;
label: string;
value: ReactNode;
onEdit?: () => void;
disabled?: boolean;
actionLabel?: string;
action?: ReactNode;
}) {
Expand All @@ -27,6 +29,7 @@ export function SettingSummaryRow({
</span>
{action ?? (
<Button
disabled={disabled}
type="button"
variant="link"
size="sm"
Expand Down
87 changes: 86 additions & 1 deletion apps/web/src/components/settings/automations/AutomationsSettings.render.client.test.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions apps/web/src/components/settings/automations/AutomationsSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3807,7 +3807,7 @@ export function AutomationsSettings({
details={automationUi.details}
frequency={frequency}
isEnabled={isEnabled}
disabled={false}
disabled={isAutomationSaving(automation.id)}
fieldId={fieldId}
onFrequencyChange={(nextFrequency) =>
setScheduleOnlyAutomationFrequency(
Expand Down Expand Up @@ -4111,7 +4111,7 @@ export function AutomationsSettings({
details={automationUi.details}
frequency={frequency}
isEnabled={isEnabled}
disabled={false}
disabled={isAutomationSaving(automation.id)}
fieldId={fieldId}
onFrequencyChange={(nextFrequency) =>
setScheduleOnlyAutomationFrequency(
Expand Down Expand Up @@ -4439,7 +4439,7 @@ export function AutomationsSettings({
details={automationUi.details}
frequency={frequency}
isEnabled={isEnabled}
disabled={false}
disabled={isAutomationSaving(automation.id)}
fieldId={fieldId}
onFrequencyChange={(nextFrequency) =>
setScheduleOnlyAutomationFrequency(
Expand Down
2 changes: 2 additions & 0 deletions apps/web/src/components/settings/automations/ScheduleOnlyAutomationContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ export function ScheduleOnlyAutomationContent({
) : editingSchedule ? (
<div className="space-y-2">
<Select
disabled={disabled}
value={frequency}
onValueChange={(value) => {
onFrequencyChange(
Expand Down Expand Up @@ -192,6 +193,7 @@ export function ScheduleOnlyAutomationContent({
</div>
) : (
<SettingSummaryRow
disabled={disabled}
icon={Calendar}
label="Schedule"
value={
Expand Down
Loading