Skip to content

[Fix] Invalid inference-provider keys pass save-time validation #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roomote-roomote wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Fix] Invalid inference-provider keys pass save-time validation #3673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 89 additions & 0 deletions apps/web/src/trpc/commands/task-models/provider-validation.native.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions packages/cloud-agents/src/server/__tests__/non-task-provider-usage.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 10 additions & 8 deletions packages/cloud-agents/src/server/non-task-provider-usage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3037,6 +3037,16 @@ export function classifyNonTaskInferenceError(
};
}

// The SDK marks credential rejections non-retryable too. Preserve their
// specific category so pre-save validation can reject a known-bad key.
if (!gatewayBlocked && (statusCode === 401 || statusCode === 403)) {
return {
message: 'The inference provider rejected these credentials.',
reason: 'invalid_credentials',
retryable: false,
};
}

if (isInferenceErrorExplicitlyNonRetryable(inferenceError)) {
return {
message: 'The inference provider rejected the request.',
Expand Down Expand Up @@ -3109,14 +3119,6 @@ export function classifyNonTaskInferenceError(
};
}

if (statusCode === 401 || statusCode === 403) {
return {
message: 'The inference provider rejected these credentials.',
reason: 'invalid_credentials',
retryable: false,
};
}

if (statusCode === 404) {
return {
message: 'The selected model is unavailable with these credentials.',
Expand Down
Loading