Repository navigation
[Refactor] Give inbound MCP authentication one request-scoped owner - #3667
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed all 10 changed files and the authentication, route mounting, and in-process member-tool dispatch paths. CI tests, lint, type checks, and Knip passed for this commit; Docker build and JavaScript/TypeScript CodeQL analysis were still running at review completion. Reviewed 1d3c10c |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
November 5, 2026 02:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Authentication ownership follow-up to #3657.
Why this PR exists
OAuth grant validation also records activity in Redis. Middleware and the member resolver both performed that transaction, while the legacy MCP resolver repeated audience/scope checks and rewrote the credential resource to reuse canonical authorization.
What changed
Impact
No intended user-facing behavior change. Each inbound OAuth request checks/touches its grant once, and every subsequent request authenticates afresh. Revocation, deleted-user rejection, Redis fail-closed behavior, and legacy audience restrictions remain enforced. Redis storage and grant state are unchanged.
How it was tested
pnpm lint/pnpm check-typeswere not separately run.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetNo changeset: behavior-preserving internal refactor.