Repository navigation
[Chore] Patch remaining Zod, MSAL and fast-uri security alerts - #3600
Conversation
|
No new code issues found. See session Reviewed the merge from Current-head CI lint, type checking, Knip, upgrade compatibility, deployment artifacts, docs validation, and fresh-host backup restore passed. Tests, app/worker Docker builds, and JavaScript/TypeScript CodeQL analysis were still running at review closeout. Repository validation suites were left to CI. No approval submitted. Reviewed fd9fe5b |
|
@roomote-roomote get this ready |
I’ll bring #3600 up to date, fix the failing CI checks, and revalidate the dependency upgrades and Zod migration. I’ll also check overlap with #3628 and refresh the PR’s validation evidence. I won’t merge it. Reply anytime · Open in Roomote |
|
Prepared and pushed fd9fe5bea37610735fa04b2612353d3a2fbadf9c, bringing in all 13 develop commits and resolving the three dependency conflicts. Before merge the branch was conflict-free and zero commits behind develop.
Final state: mrubens merged this PR at 2026-11-01 00:44:52 UTC while evidence closeout was underway. The resulting develop commit is 249d87b97c34eb3c7450855b56be1e6940c84fe0; its tree matches the tested head. No remaining code/CI blocker was observed. I did not approve, bypass protection, merge the PR or deploy anything. No new PR was opened. |
…ency-alerts-3exo5blaim3f7
Related issue
Addresses the remaining Zod, MSAL and fast-uri alerts from the original 29-alert runtime bundle: 20 Zod alerts (#279, #280, #282–#291, #293–#300), two MSAL alerts (#281, #309), and four fast-uri alerts (#302–#305). The three undici alerts originally included here are already covered by merged #3615.
Why this PR exists
Complete the runtime security upgrade and Zod compatibility migration. The readiness request authorized preparation only. After current-head CI passed, mrubens merged this PR at November 1, 2026, 00:44:52 UTC, during evidence closeout. This readiness run did not perform the PR merge or any deployment.
What changed
@azure/msal-nodepnpm-workspace.yaml,minimumReleaseAge: 10080and every exclusion remain byte-for-byte unchanged from both the original PR and current develop.Current develop integration and overlap
Merged develop 66bdd0a into this branch and resolved the three manifest/lock conflicts by combining security intent:
There is no intended user-visible behavior change. The benefit is removal of the remaining vulnerable Zod/MSAL/URI resolutions while preserving normal validation, authentication and runtime behavior. The migration necessarily spans shared schema consumers; no new product options or unrelated refactors were added. GitHub alert closure still depends on default-branch integration and dependency rescanning; no alerts were dismissed.
How it was tested
Current evidence applies to fd9fe5b, superseding the October 27 evidence and its Kimi exception.
fetch/Agentcompleted a real local HTTP round trip. Replay script. No live external account or exploit reproduction was used.Screenshots
Authenticated home on the updated dependency graph:
The real YAML form rejects an empty name:
After correcting the input, the same form renders a valid preview:
These screenshots prove the rendered local compatibility states, not external-provider OAuth, persisted environment creation, task execution, or hosted-runtime parity.
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetOne cohesive security bundle with broad but mechanical Zod compatibility changes. Normal local fast lint/type gates and hosted full static checks were used; formatting-inclusive local aliases were not run. No changeset was added.