fix: match tagged toml values in release-please lockfile filters - #92
Merged
Conversation
The generic-toml updater parses every scalar as a tagged
{start, end, value} node, so a filter comparing @.name to a string can
never match and the uv.lock pins were silently skipped ("No entries
modified" in every release-please run). Filtering on @.name.value
matches the actual string; the target .version stays on the tagged node
the surgical replacer expects.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
area:ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PRs never carried the uv.lock version pins: the TOML updater wraps every parsed scalar as a tagged {start,end,value} node, so
@.name=='x'compares an object to a string and never matches. Filter on@.name.valueinstead — all five package entries plus the CONTRIBUTING snippet.🤖 Generated with Claude Code