feat(operator): add Snapshot and SnapshotContent v1alpha1 CRDs#1
Merged
Conversation
Introduce namespaced Snapshot and cluster-scoped SnapshotContent (nvidia.com/v1alpha1) as the artifact-of-record for checkpoint capture. Minimal-trigger Snapshot.spec (checkpointID + source.podRef); self-contained SnapshotContent.snapshotHandle; conditions-based status; whole spec immutable via CEL. Types only -- no controller, webhook, or RBAC yet; inert until later components. Single-version, no conversion. Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Ronkahn21
added a commit
that referenced
this pull request
Jun 10, 2026
Introduce namespaced Snapshot and cluster-scoped SnapshotContent (nvidia.com/v1alpha1) as the artifact-of-record for checkpoint capture. Minimal-trigger Snapshot.spec (checkpointID + source.podRef); self-contained SnapshotContent.snapshotHandle; conditions-based status; whole spec immutable via CEL. Types only -- no controller, webhook, or RBAC yet; inert until later components. Single-version, no conversion. Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Ronkahn21
added a commit
that referenced
this pull request
Jun 11, 2026
Introduce namespaced Snapshot and cluster-scoped SnapshotContent (nvidia.com/v1alpha1) as the artifact-of-record for checkpoint capture. Minimal-trigger Snapshot.spec (checkpointID + source.podRef); self-contained SnapshotContent.snapshotHandle; conditions-based status; whole spec immutable via CEL. Types only -- no controller, webhook, or RBAC yet; inert until later components. Single-version, no conversion. Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Ronkahn21
added a commit
that referenced
this pull request
Jun 22, 2026
Introduce namespaced Snapshot and cluster-scoped SnapshotContent (nvidia.com/v1alpha1) as the artifact-of-record for checkpoint capture. Minimal-trigger Snapshot.spec (checkpointID + source.podRef); self-contained SnapshotContent.snapshotHandle; conditions-based status; whole spec immutable via CEL. Types only -- no controller, webhook, or RBAC yet; inert until later components. Single-version, no conversion. Signed-off-by: Ron Kahn <rkahn@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Component A of the DynamoCheckpoint → Snapshot/SnapshotContent migration: add the two new CRD types. Additive only — zero behavior change (no controller, webhook, or RBAC yet; CRDs are inert until later components).
Internal staging PR into the long-lived base branch
feat/snapshot-crd(within this fork).Details:
nvidia.com/v1alpha1kinds:Snapshot(namespaced,snap) — minimal "trigger" spec:checkpointID(immutable artifact identity / on-PVC dir name) +source.podRef.name. The node agent reads target-container / storage base path from the source pod's existing annotations & mounts, so they are not duplicated in spec.SnapshotContent(cluster-scoped,snapcontent) — artifact-of-record:snapshotRefback-pointer + self-containedsource.snapshotHandle(pvc://<ns>/<claim>/<basePath>/<checkpointID>/versions/<version>).metav1.Conditions(Ready/Failed), matchingDynamoCheckpoint/DynamoModelstyle.specis immutable via a single CEL rule:!has(oldSelf.spec) || self.spec == oldSelf.spec.config/crd/kustomization.yamlupdated.+genclient, no+kubebuilder:storageversion, no+kubebuilder:rbac. Single-version ⇒ no conversion (documented).Verification (sandbox off):
make manifestsclean, helm copies in sync,go build ./...+go test ./api/v1alpha1pass. CodeRabbit: no findings.Where should the reviewer start?
deploy/operator/api/v1alpha1/snapshot_types.godeploy/operator/api/v1alpha1/snapshotcontent_types.godeploy/operator/api/v1alpha1/snapshot_types_test.goEverything else is generated (
zz_generated.deepcopy.go,config/crd/bases/*, helm copies) or a 2-linekustomization.yamlchange.Related Issues
🚫 This PR is NOT linked to an issue:
ai-dynamo/dynamo)