Add can use folders hook - #134
Open
veliseev93 wants to merge 2 commits into
Open
veliseev93 wants to merge 2 commits into
veliseev93 wants to merge 2 commits into
Conversation
VitalyMih
reviewed
Sep 14, 2026
VitalyMih
left a comment
VitalyMih
left a comment
Contributor
There was a problem hiding this comment.
@veliseev93 couple questions :)
| isLoading: boolean; | ||
| } | ||
|
|
||
| export function useCanUseFolders(): UseCanUseFoldersResult { |
Contributor
There was a problem hiding this comment.
useCanUseFolders reads a bit awkward ("use can use"). Since this returns whether the folders feature is available, something like useFoldersEnabled would read more naturally. What do you think?
| (profile?.role === UserRole.ADMIN || (profile?.permissions.features.folders ?? true)), | ||
| ); | ||
|
|
||
| return { canUseFolders, isLoading: isConfigLoading || isProfileLoading }; |
Contributor
There was a problem hiding this comment.
isLoading isn't used anywhere in the app currently. Is it intended for future use, or should we drop it from the hook's return value for now?
Collaborator
Author
|
@VitalyMih Thank you, fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed error when folders are disabled in admin panel