-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Implement setNamespace method #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
94ee5d5
f34e2fb
46e439d
b3631d2
8b24a6b
3311be1
485946f
3072a59
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <?php | ||
|
|
||
| namespace RonasIT\Larabuilder\Visitors; | ||
|
|
||
| use PhpParser\Node\Name; | ||
| use PhpParser\Node\Stmt\Class_; | ||
| use PhpParser\Node\Stmt\Declare_; | ||
| use PhpParser\Node\Stmt\Enum_; | ||
| use PhpParser\Node\Stmt\Interface_; | ||
| use PhpParser\Node\Stmt\Namespace_; | ||
| use PhpParser\Node\Stmt\Trait_; | ||
|
|
||
| class SetNamespace extends AbstractNodeVisitor | ||
| { | ||
| protected array $allowedParentNodesTypes = [ | ||
| Class_::class, | ||
| Trait_::class, | ||
| Enum_::class, | ||
| Interface_::class, | ||
| ]; | ||
|
|
||
| public function __construct( | ||
| protected string $namespace, | ||
| ) { | ||
| } | ||
|
|
||
| public function afterTraverse(array $nodes): ?array | ||
| { | ||
| parent::afterTraverse($nodes); | ||
|
|
||
| $declares = []; | ||
|
|
||
| foreach ($nodes as $key => $node) { | ||
| if ($node instanceof Namespace_) { | ||
| return $this->updateNamespace($node); | ||
| } | ||
|
|
||
| if ($node instanceof Declare_) { | ||
| $declares[] = $node; | ||
|
|
||
| unset($nodes[$key]); | ||
| } | ||
| } | ||
|
|
||
| return [...$declares, new Namespace_(new Name($this->namespace), array_values($nodes))]; | ||
| } | ||
|
|
||
| protected function updateNamespace(Namespace_ $node): ?array | ||
| { | ||
| if ($node->name->toString() !== $this->namespace) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When Useful? React with 👍 / 👎. |
||
| $node->name = new Name($this->namespace); | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| class SomeClass | ||
| { | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace App\Models; | ||
|
|
||
| class SomeClass | ||
| { | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <?php | ||
|
|
||
| namespace App\Models; | ||
|
|
||
| enum SomeEnum | ||
| { | ||
| case First; | ||
| case Second; | ||
|
|
||
| public static function toArray(): array | ||
| { | ||
| return self::cases(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new namespace insertion path hoists every top-level
declareout of its original position before wrapping the rest of the file innamespace ...;. This changes runtime behavior for valid files that use non-strict_typesdeclares (for exampledeclare(ticks=1);) after some statements, because the directive is now applied from the top of the script. To avoid semantic changes, only preserve leadingdeclare(strict_types=1)(or otherwise reject unsupported declare layouts) instead of relocating allDeclare_nodes.Useful? React with 👍 / 👎.