Repository navigation
Season numbering from Sonarr (TVDB) instead of TMDB - #31
Merged
Merged
Conversation
…end seasonNumbering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tipsarr listed TV seasons from TMDB, but Sonarr, the Jellyfin folders and users use TVDB numbering. For Bleach (TMDB 30984) TMDB has 2 seasons and TVDB has 17. A request for "season 2" (the Thousand-Year Blood War arc) monitored Sonarr season 2, a different arc.
What changes
seasonNumbering: "tmdb").media.Detailtakes an injectedSeasonSource, only for callers that opt in (Opts.Seasons), so no path can show TMDB seasons by mistake. A TVDB season borrows a TMDB name/poster only when first air date and episode count both match (Bleach S17 = TMDB S2).requests.season_numbering, migration 032). Rows made before this, or while Sonarr was unreachable, aretmdband are checked at approval: a request that cannot be mapped fails instead of monitoring the wrong season.season_numbering_changed.MonitorSeasons, never unmonitors); it used to do nothing./media/tv/{id}/seasons/{n}) uses the TVDB number and can return an empty episode list.seasonNumberingsent with requests. API additions are additive, so shipped apps keep working.Testing
go test -count=1 ./...,go vet,gofmt,npm run check,check:i18n,npm run build.tmdbrows, imports, migration backfill (SQLite only).Not verified
seasonNumberingnames on iOS before release.After merge
Existing wrong requests are not rewritten. The Bleach request made with season 2 has to be fixed by hand in Sonarr.