Skip to content

iOS: fixes found while taking the 1.0 store screenshots - #26

Merged
Rombond merged 8 commits into
masterfrom
fix-ios-shots
Nov 12, 2026
Merged

Rombond merged 8 commits into
masterfrom
fix-ios-shots

Conversation

@Rombond

@Rombond Rombond commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Fixes seen while taking the App Store screenshots for 1.0.

iPhone and iPad

  • Statistics: singular/plural counts ("1 play"), most-watched captions on two lines.
  • TMDB department of people translated (search card, list row, person screen).
  • Discover follows a new phone language/region after relaunch, without signing out; the server drops stored suggestion rows when the language changes (test in suggestions_test.go). Docs: "Language and region" in docs/mobile-apps.md.
  • Device-neutral wording ("this device") instead of "this iPhone".
  • Sign-out closes Settings/Profile first; no notification prompt while signing out.

iPad

  • Profile sheet at page size, so Statistics and most-watched captions fit.
  • Request sheet sized to its content, Request/Cancel pinned under the form.
  • Wider Search column so the scope segments are not cut ("Personnes").

Checked on iPad Pro 13" and iPhone 18 Pro Max simulators (iOS 27.2); make test passes. Not ported to Android/web yet ("1 plays", raw department, region only when empty).

…ines

"1 plays" / "1 lectures" under a title watched once, and the same for the other counters of the Statistics page
(movies and shows, available and declined requests, titles per decade, never watched, and N more). New mobile
strings m.stats.* carry one and other forms; the web keys stay as they are (Android reads them directly).
Poster captions ("6,9 h · 8 épisodes regardés") wrap to two lines instead of being cut, with the space kept so
the cards line up. The iOS catalog is regenerated (it also picks up strings that were already in locales/).
Search cards and the person screen showed TMDB's known_for_department as sent ("Acting"). It now goes through the
dept.* strings the web app already uses, falling back to TMDB's text for an unknown department.
iOS saved the phone's region only when the profile had none, so after a change of language and region it kept
the old one (box office, release dates) until a new sign-in. The app now records the region it saved by itself
and replaces it with the phone's current one at launch; a region picked in Settings (or on the web or Android)
is kept. Language and region go in one update, and the tabs are rebuilt when the profile language changes too,
since Discover was loaded with the old one.
Server: a language change dropped nothing and only queued a background refresh, so the suggestion rows kept
titles and posters in the old language until a suggestions.updated event reached the app. The rows are now
deleted, and the next read builds them in the new language.
@Rombond
Rombond merged commit 4606c72 into master Nov 12, 2026
4 checks passed
@Rombond
Rombond deleted the fix-ios-shots branch November 12, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant