Skip to content

[WIP] Centralize package metadata and dependency versions - #12

Merged
Romain-OD merged 4 commits into
mainfrom
copilot/centralize-package-metadata
Oct 26, 2026
Merged

Romain-OD merged 4 commits into
mainfrom
copilot/centralize-package-metadata

Conversation

Copilot AI commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Plan

  • Capture baseline dotnet pack output (10 packages @ 2.1.0) for metadata comparison
  • Create Directory.Build.props at repo root with shared metadata (Version 2.1.0, Authors, license, URLs, readme/icon, GenerateDocumentationFile) + compiler settings (ImplicitUsings, Nullable, LangVersion)
  • Create Directory.Packages.props with ManagePackageVersionsCentrally and one PackageVersion per distinct package (all 30 dependency versions in use)
  • Update all 22 .csproj files: remove shared metadata (packable projects keep PackageId/Description/PackageTags), remove inline Version attributes from all PackageReference items, preserve per-file BOM encoding
  • Fix GenerateDocumentationFile flow: suppress CS1591 for non-packable projects in Directory.Build.targets
  • Verify dotnet build clean (54 warnings = baseline, 0 errors), dotnet test passes, dotnet pack metadata + contents byte-equivalent to baseline (only source commit SHA differs)
  • Run secret scan (clean) + parallel validation (CodeQL: no analyzable code; review: no issues)

Done — all acceptance criteria met:

  • ✅ Directory.Build.props holds shared metadata; a release changes <Version> in exactly one file
  • ✅ Directory.Packages.props exists with ManagePackageVersionsCentrally; no .csproj carries an inline Version attribute
  • ✅ Each .csproj retains its own PackageId, Description, PackageTags
  • ✅ dotnet build MessageValidation.slnx -c Release succeeds with no new warnings (54 = baseline, 0 errors)
  • ✅ dotnet pack output byte-equivalent in metadata to current 2.1.0 packages (same version, license, icon, readme, docs XML)

…ild.props and Directory.Packages.props

Co-authored-by: Romain-OD <31764259+Romain-OD@users.noreply.github.com>
@Romain-OD
Romain-OD marked this pull request as ready for review October 20, 2026 16:01
@Romain-OD

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

Copilot AI and others added 2 commits October 21, 2026 13:03
Co-authored-by: Romain-OD <31764259+Romain-OD@users.noreply.github.com>
Keep centralized package metadata in Directory.Build.props and add main's
PackageReleaseNotes to each packable project; union SourceLink/symbol/CI-build
properties with the centralized metadata.

Co-authored-by: Romain-OD <31764259+Romain-OD@users.noreply.github.com>

Copilot AI commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in d900965.

Main had added SourceLink/deterministic-build/symbol-package settings in a new Directory.Build.props and a PackageReleaseNotes (CHANGELOG.md) line in each packable .csproj, which collided with this branch's centralization of that same metadata.

Resolution:

  • Directory.Build.props is the union of both — centralized metadata/compiler settings plus main's SourceLink/symbol/CI-build properties.
  • Each packable .csproj keeps its centralized form and gains main's PackageReleaseNotes.

Validated: dotnet build clean (0 errors), all tests pass, and dotnet pack produces the 10 packages at 2.1.0 plus .snupkg symbol packages with the merged metadata intact.

@Romain-OD
Romain-OD merged commit 2d14c1e into main Oct 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Centralize package metadata and dependency versions with Directory.Build.props and Directory.Packages.props

2 participants