Repository navigation
[WIP] Centralize package metadata and dependency versions - #12
Merged
Merged
Conversation
5 tasks
…ild.props and Directory.Packages.props Co-authored-by: Romain-OD <31764259+Romain-OD@users.noreply.github.com>
Copilot stopped work on behalf of
Romain-OD due to an error
October 14, 2026 16:29
Romain-OD
approved these changes
Oct 20, 2026
Romain-OD
marked this pull request as ready for review
October 20, 2026 16:01
Owner
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: Romain-OD <31764259+Romain-OD@users.noreply.github.com>
Keep centralized package metadata in Directory.Build.props and add main's PackageReleaseNotes to each packable project; union SourceLink/symbol/CI-build properties with the centralized metadata. Co-authored-by: Romain-OD <31764259+Romain-OD@users.noreply.github.com>
Contributor
Author
Merge conflicts resolved in d900965. Main had added SourceLink/deterministic-build/symbol-package settings in a new Resolution:
Validated: |
Romain-OD
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan
dotnet packoutput (10 packages @ 2.1.0) for metadata comparisonDirectory.Build.propsat repo root with shared metadata (Version2.1.0,Authors, license, URLs, readme/icon,GenerateDocumentationFile) + compiler settings (ImplicitUsings,Nullable,LangVersion)Directory.Packages.propswithManagePackageVersionsCentrallyand onePackageVersionper distinct package (all 30 dependency versions in use).csprojfiles: remove shared metadata (packable projects keepPackageId/Description/PackageTags), remove inlineVersionattributes from allPackageReferenceitems, preserve per-file BOM encodingGenerateDocumentationFileflow: suppress CS1591 for non-packable projects inDirectory.Build.targetsdotnet buildclean (54 warnings = baseline, 0 errors),dotnet testpasses,dotnet packmetadata + contents byte-equivalent to baseline (only source commit SHA differs)Done — all acceptance criteria met:
Directory.Build.propsholds shared metadata; a release changes<Version>in exactly one fileDirectory.Packages.propsexists withManagePackageVersionsCentrally; no.csprojcarries an inlineVersionattribute.csprojretains its ownPackageId,Description,PackageTagsdotnet build MessageValidation.slnx -c Releasesucceeds with no new warnings (54 = baseline, 0 errors)dotnet packoutput byte-equivalent in metadata to current 2.1.0 packages (same version, license, icon, readme, docs XML)