Open
Conversation
calebwoods
reviewed
Feb 22, 2023
| require_relative '../../../bundler_helpers' | ||
|
|
||
| module Rolemodel | ||
| module Saas |
Member
There was a problem hiding this comment.
Ok. I see that's nesting approach. Could see it simply being rolemodel:blazer
| def add_styles | ||
| copy_file 'app/assets/stylesheets/blazer.css' | ||
| copy_file 'app/assets/stylesheets/selectize.css' | ||
| append_to_file 'app/assets/config/manifest.js', "\n//= link blazer.css" |
Member
There was a problem hiding this comment.
This will be different base on the CSS approach being used right?
Member
There was a problem hiding this comment.
I defer to @reedrolemodel on that one. I forget why we needed that.
Contributor
Author
There was a problem hiding this comment.
Yes, this assumes sprockets is being used which is also an assumption of blazer. This issue is for adding support for jsbundling and cssbundling to blazer. Until more gems support newer approaches, it seems likely that sprockets will be needed.
timirwin
reviewed
Oct 10, 2023
| if File.readlines('Gemfile').grep(/capybara|webdrivers/).none? | ||
| gem_group :test do | ||
| gem 'capybara' unless File.readlines('Gemfile').grep(/capybara/).any? | ||
| gem 'webdrivers' unless File.readlines('Gemfile').grep(/webdrivers/).any? |
timirwin
reviewed
Oct 10, 2023
| end | ||
|
|
||
| def add_tests | ||
| copy_file 'spec/factories/blazer_queries.rb' |
Member
There was a problem hiding this comment.
Should we be copying blazer_dashboards.rb too?
Suggested change
| copy_file 'spec/factories/blazer_queries.rb' | |
| copy_file 'spec/factories/blazer_dashboards.rb' | |
| copy_file 'spec/factories/blazer_queries.rb' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
TR #400
Why?
Blazer is quickly becoming a tool that we reach for on almost every project. What is missing from our use of it? What common customizations or fixes can we package?
A few things we could/should do
Switch from passing SQL back and forth in Blazer (except where absolutely necessary) to eliminate SQL injection.
Could also package Blazer for non-admin reporting as used on BGEA & Maverick
And one last thing is to create a rolemodel_rails generator
What Changed
What changed in this PR?
Screenshots
If any UI changes need to be shown off, please add screenshots here.