CI check only (fork): fix/safe-sub-parens - #1
Open
Rodrigo-Palma wants to merge 1 commit into
Open
Rodrigo-Palma wants to merge 1 commit into
Rodrigo-Palma wants to merge 1 commit into
Conversation
…ounding operators The optimizer collapses the CASE built by SAFE_ADD/SAFE_SUB into its ELSE branch without parentheses, so an enclosing operator swallows an operand. Emit the ELSE arithmetic as an explicit Paren. SAFE_DIV now returns its quotient wrapped in a Paren so x / @SAFE_DIV(a, b) keeps its grouping. Closes SQLMesh#5649 Signed-off-by: Rodrigo-Palma <email.rodrigopalma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal PR on my own fork, opened only to run this repository's CI on the branch of the upstream PR, whose workflow runs are waiting on maintainer approval. Not for merge. SQLMesh#6074