feat: keep opened room visible in sidebar collapsed categories - #42108
feat: keep opened room visible in sidebar collapsed categories#42108dougfabris wants to merge 1 commit into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: faeb6af The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #42108 +/- ##
=========================================
Coverage 69.41% 69.42%
=========================================
Files 4310 4310
Lines 177068 177441 +373
Branches 31500 31502 +2
=========================================
+ Hits 122910 123180 +270
- Misses 49045 49160 +115
+ Partials 5113 5101 -12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Collapsing a sidebar category hid every room in it, including the one you were currently viewing — leaving no indication of where you were in the sidebar.
The open room now stays listed under its category while collapsed.
useRoomListreads it fromuseOpenedRoom()and folds it into the existing collapsed-visibility rule:The collapsed header badge now counts only the rooms the group actually hides, so the open room isn't counted both in its own row badge and in the header.
Issue(s)
Steps to test or reproduce
Further comments
SCC-34