Skip to content

feat: keep opened room visible in sidebar collapsed categories - #42108

Draft
dougfabris wants to merge 1 commit into
developfrom
feat/keep-opened-room
Draft

feat: keep opened room visible in sidebar collapsed categories#42108
dougfabris wants to merge 1 commit into
developfrom
feat/keep-opened-room

Conversation

@dougfabris

@dougfabris dougfabris commented Sep 11, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

image

Collapsing a sidebar category hid every room in it, including the one you were currently viewing — leaving no indication of where you were in the sidebar.

The open room now stays listed under its category while collapsed. useRoomList reads it from useOpenedRoom() and folds it into the existing collapsed-visibility rule:

const isVisibleWhileCollapsed = (room) => room.rid === openedRoom || (showUnreads && isUnreadRoom(room));

The collapsed header badge now counts only the rooms the group actually hides, so the open room isn't counted both in its own row badge and in the header.

Issue(s)

Steps to test or reproduce

Further comments

SCC-34

Review in cubic

@dougfabris dougfabris added this to the 8.9.0 milestone Sep 11, 2026
@dionisio-bot

dionisio-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: faeb6af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.42%. Comparing base (f18f33c) to head (faeb6af).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #42108    +/-   ##
=========================================
  Coverage    69.41%   69.42%            
=========================================
  Files         4310     4310            
  Lines       177068   177441   +373     
  Branches     31500    31502     +2     
=========================================
+ Hits        122910   123180   +270     
- Misses       49045    49160   +115     
+ Partials      5113     5101    -12     
Flag Coverage Δ
e2e 58.98% <83.33%> (-0.01%) ⬇️
e2e-api 46.34% <ø> (ø)
unit 70.63% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant