Skip to content

test: fix flaky login after E2EE password reset - #42095

Draft
jessicaschelly wants to merge 1 commit into
developfrom
test/e2ee-password-reset-login-flake
Draft

jessicaschelly wants to merge 1 commit into
developfrom
test/e2ee-password-reset-login-flake

Conversation

@jessicaschelly

@jessicaschelly jessicaschelly commented Sep 10, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Fixes the flaky final login in should reset e2e password from the modal by clearing Accounts._lastLoginTokenWhenPolled before polling the restored login token in loginByUserState().

When the restored token matches Meteor's cached value, _pollStoredLoginToken() can skip authentication and leave the test on the login screen. Resetting the cached value forces a fresh login attempt and follows the existing pattern in stubMeteorStream.ts. The helper retains its existing UI assertions to wait for login completion.

Issue(s)

FLAKY-1581

Steps to test or reproduce

Further comments

In the original CI job, the reset endpoint returned HTTP 200 with success: true. The failure occurred during the final login, where the Login button remained visible for five seconds.

Review in cubic

@dionisio-bot

dionisio-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8d3a961

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.62%. Comparing base (781a3bc) to head (8d3a961).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #42095      +/-   ##
===========================================
+ Coverage    69.61%   69.62%   +0.01%     
===========================================
  Files         4306     4306              
  Lines       172267   172267              
  Branches     31289    31250      -39     
===========================================
+ Hits        119919   119938      +19     
+ Misses       47149    47130      -19     
  Partials      5199     5199              
Flag Coverage Δ
unit 71.36% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant