test: fix flaky login after E2EE password reset - #42095
jessicaschelly wants to merge 1 commit into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #42095 +/- ##
===========================================
+ Coverage 69.61% 69.62% +0.01%
===========================================
Files 4306 4306
Lines 172267 172267
Branches 31289 31250 -39
===========================================
+ Hits 119919 119938 +19
+ Misses 47149 47130 -19
Partials 5199 5199
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Fixes the flaky final login in
should reset e2e password from the modalby clearingAccounts._lastLoginTokenWhenPolledbefore polling the restored login token inloginByUserState().When the restored token matches Meteor's cached value,
_pollStoredLoginToken()can skip authentication and leave the test on the login screen. Resetting the cached value forces a fresh login attempt and follows the existing pattern instubMeteorStream.ts. The helper retains its existing UI assertions to wait for login completion.Issue(s)
FLAKY-1581
Steps to test or reproduce
Further comments
In the original CI job, the reset endpoint returned HTTP 200 with
success: true. The failure occurred during the final login, where the Login button remained visible for five seconds.