Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
/jira ARCH-1592 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
🔇 Additional comments (1)
WalkthroughThe Debian Docker build changes its Node.js base image from Debian Bullseye slim to Debian Bookworm slim. ChangesDocker base image
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The Debian container now uses the Bookworm slim base image without an evidenced compatibility issue. The change is mergeable. Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Errors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Debian 11 (bullseye) left Debian LTS security support on 2026-08-31, so the published Debian image no longer receives OS security updates. Bookworm is supported until 2028-06-30 and ships GCC 12 / glibc 2.36, matching the fully C++20-capable toolchain the alpine image already has. Node version is intentionally unchanged.
9a4bfb5 to
4aa5b87
Compare
|
/jira ARCH-1592 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #42085 +/- ##
===========================================
- Coverage 69.47% 69.46% -0.02%
===========================================
Files 4300 4302 +2
Lines 171755 171764 +9
Branches 31069 31156 +87
===========================================
- Hits 119329 119318 -11
- Misses 47224 47262 +38
+ Partials 5202 5184 -18
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1 participant
Proposed changes (including videos or screenshots)
Bumps the base image of
apps/meteor/.docker/Dockerfile.debianfrom the Debian 11 (bullseye) variant to the Debian 12 (bookworm) variant:The Node version is intentionally not changed here — this PR is only the Debian variant move.
Why
1. bullseye is out of security support.
Debian 11 left regular support on 2024-08-15 and its LTS window ended on 2026-08-31 (Debian LTS wiki). From that date on, the Debian image we publish stops receiving OS security updates unless someone pays for ELTS. Bookworm is supported until 2028-06-30.
2.
isolated-vm6.x needs a full C++20 toolchain.developnow pinsisolated-vm@6.2.0(since #41097 landed), which requires full C++20. The bullseye image only provides GCC 10.2, whose C++20 support is partial — so if that install ever falls back to a source compile instead of a prebuilt binary, the Debian image build breaks. Bookworm brings GCC 12 and glibc 2.36.3. Toolchain parity with the alpine image.
Dockerfile.alpinealready builds onalpine3.23and gets a fully C++20-capable toolchain. This brings the Debian image in line rather than leaving the two published images on materially different compilers.Verification
node:24.15.0-bookworm-slimexists on Docker Hub.Dockerfile.debianfor anything Debian-11-specific: there is nothing pinned to bullseye. The apt packages installed (fontconfig,g++,make,python3,ca-certificates) all exist under the same names in bookworm, there are no third-party apt repos or pinned lib versions, and thedenostage copies a static binary fromdenoland/deno:bin-*(unaffected by the host distro, and a newer glibc is backward compatible for it).Issue(s)
ARCH-1592
Steps to test or reproduce
Build the Debian image and confirm it starts:
Further comments
Found while working on #41097 (Meteor 3.5 / Node 24) — raised there in this review comment. It is an independent base-image upgrade rather than part of the Meteor/Node bump, so it was split out into this PR to keep #41097 scoped. #41097 has since merged, so this now applies on top of Node 24.
No changeset. Matching precedent in this repo: the comparable image changes — #40536 (Node bump), #40389 (Meteor/Node bump) and #40128 (slim Docker image, which visibly changed the published image) — all landed without one, and there is no CI gate requiring a changeset. Happy to add one if maintainers want the base OS bump called out in the release notes.
Debian 13 (trixie) variants also exist for this Node version. Bookworm is the conservative step and the one raised in review; trixie can be a separate follow-up.
Summary by CodeRabbit
Task: ARCH-2405