Repository navigation
[DOCS] Align Node.js requirement in docs README with package.json eng… - #1397
Merged
Aryan-Verma-999 merged 1 commit intoOct 23, 2026
Conversation
|
|
Aryan-Verma-999
approved these changes
Oct 23, 2026
Collaborator
|
LGTM, Thanks for the contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update the Node.js requirement in
packages/docs/README.mdfrom v22 to v24 (LTS) to reflect the"engines": { "node": ">=24.0.0" }specification defined inpackages/docs/package.json.Motivation
While the root repository was recently updated to require Node 24 via
.nvmrcandscripts/node-check.js,packages/docs/README.mdstill instructed contributors to install Node 22 (nvm install 22). Becausepackages/docs/package.jsonenforces"node": ">=24.0.0", following the existing docs instructions leads to installation errors when working on the documentation site.Testing
enginesfield inpackages/docs/package.json..nvmrc(v24.0.0).