Skip to content

Ghost Session: WebSocket Connection Leaks After Logout #1158

Open
rohanesor/EmbeddedChat
#4

Description

@deepak0x

The logout function in packages/api/src/EmbeddedChatApi.ts fails to disconnect the WebSocket client (this.rcClient). It only calls this.auth.logout(), which removes the authentication token but leaves the socket connection active. Consequently, the application continues to receive live messages and events for the previous session even after the user has visibly "logged out," leading to privacy leaks and inconsistent state if a new user logs in without a full page refresh.

Steps to reproduce:

  1. Login to EmbeddedChat and enter a room.
  2. Open the browser's Developer Tools and navigate to the Network tab.
  3. Filter by "WebSocket" to see the active connection.
  4. Call api.logout() or click the Logout button in the UI.
  5. Observe that the WebSocket connection remains active (status 101 Switching Protocols) and frames continue to be received.

Expected behavior:

Logout should fully terminate the session. The function must call this.rcClient.disconnect() and this.rcClient.unsubscribeAll() to clean up resources and stop receiving data.

Actual behavior:

Image

The WebSocket connection remains active, and the client continues to receive real-time updates for the logged-out user's session.

Activity

  1. kanaksharma9 commented on Feb 25, 2026

    @kanaksharma9

    Hey, I'd like to work on this issue, will share my findings soon.

  2. rohanesor commented on Oct 18, 2026

    @rohanesor

    I'd like to work on this.

    Confirmed still present on develop (8c542970): EmbeddedChatApi.logout() only awaits this.auth.logout(), which clears the token but never tears down the realtime connection. The class already has a close() method that stops _activeSubscriptions and calls sdk.connection.close() — logout() simply never calls it.

    Credit where due: @Aryan-Verma-999's earlier #1171 identified the same root cause; it was closed unmerged. I plan to build on that, with one difference: tearing down in a finally block so the socket is also closed when the logout request itself fails (otherwise a failed logout still leaves a live session).

    Verification: packages/api has no test runner ("test": "echo \"Error: no test specified\""), so I'll verify manually via DevTools → Network → WS, showing the connection open after logout on develop and closed after the fix, and include before/after captures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions