Full Rebuild (Sync) March 2026: bump ros-distro-mutex to 0.7.0 and build_number to 24#557
Conversation
|
Id like to help! :) |
I gave you access to the fork, feel free to push directly there in the |
|
Thanks! I pushed a number of (mostly windows) related fixes. Will continue later. |
The upstream source at release/noetic/rosbag/1.17.4-1 now uses conditional compilation (#if BOOST_VERSION < 107200) for boost headers.
|
I just tried to fix rosbash but it looks like the zsh implementation has changed quite a bit. I let my AI assistant cobble something together but I dont really trust it enough. |
|
Should we try to use |
The upstream source already removed add_compile_options(-std=c++11). Regenerated patch to only add OpenCV find_package and linking.
The upstream source at release/noetic/rosgraph/1.17.4-1 already has Python 3.11+ compatibility handling with conditional logic.
The upstream source at release/noetic/rospack/2.6.4-1 already handles APPLE-specific library exclusion using a package_libraries variable.
The upstream source already has the boost filesystem API updates (fs::extension). Regenerated patch without those already-applied changes.
The upstream source at release/noetic/topic_tools/1.17.4-1 already includes the <thread> header that this patch was adding.
The upstream source at release/noetic/tf2_py/0.7.10-1 already includes the APPLE-specific Python linking and -undefined dynamic_lookup flags.
The upstream source at release/noetic/tf/1.13.4-1 already removed the C++11 checking logic. Regenerated patch with only NO_ERROR and sys/time.h changes.
Done in traversaro@596aa7a . |
|
I can have a look at the zsh patch on Monday, but I am also fine with just removing it. |
Refactor run_rattler_build to run recipes individually and report results. Better for debugging.
Tobias-Fischer
changed the title
|
Hard to believe but it's all green now and ready for review @traversaro @wolfv |
There was a problem hiding this comment.
Pull request overview
This PR performs a full rebuild sync for the ros-noetic repository, aligning it with other RoboStack repos by switching to a unified vinca.yaml, bumping the ros-distro-mutex to 0.7.0, updating build tooling, and applying numerous patches for compatibility with newer Boost, Qt, and compiler versions.
Changes:
- Unified per-platform
vinca_*.yamlfiles into a singlevinca.yamlapproach, removed old platform-specific configs and legacy constructor/installer scripts - Updated build infrastructure: Python 3.12, rattler-build 0.57, vs2022 compiler, new
conda_build_config.yamlpins, CI caching, and patch validation tooling - Added/updated many patches for C++14 compatibility, Boost.Asio
io_contextmigration, Qt5 enforcement, and cross-compilation fixes
Reviewed changes
Copilot reviewed 133 out of 136 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vinca_osx_arm64.yaml, vinca_linux_aarch64.yaml | Removed per-platform vinca configs in favor of unified approach |
| vinca.yaml (implicit) | Now generated/used directly by vinca per platform |
| robostack.yaml | Updated dependency mappings (cargo, google-mock, gtk2, etc.) |
| conda_build_config.yaml | Bumped pins for numpy, protobuf, spdlog, libopencv, etc.; switched to vs2022, Python 3.12 |
| pixi.toml | Updated tooling versions, simplified tasks, removed per-platform rename tasks |
| pkg_additional_info.yaml | Replaced build_number overrides with generate_dummy_package_with_run_deps entries |
| rosdistro_additional_recipes.yaml | New file for jackal packages not in upstream rosdistro |
| patch/dependencies.yaml | Updated OpenGL deps from REQUIRE_OPENGL to explicit per-platform packages |
| patch/*.patch (many) | C++14 upgrades, Boost.Asio modernization, Qt5 fixes, cross-compilation fixes |
| .github/workflows/*.yml | CI modernization: caching, unified recipe generation, patch checking |
| check_patches_clean_apply.py, build_gap_report.py | New utility scripts for patch validation and build gap reporting |
| AGENTS.md | New contributor documentation for coding agents |
| additional_recipes/* | Removed manually maintained recipes (jackal, eigenpy, etc.) now handled via vinca |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Incredible, great work! Go for me, modulo probably the copilot comments that seems correct. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@copilot open a new pull request to apply changes based on the comments in this thread |
There was a problem hiding this comment.
Pull request overview
This PR performs a full rebuild sync for ROS Noetic, bumping ros-distro-mutex to 0.7.0 and build_number to 24. It unifies per-platform vinca_*.yaml files into a single vinca.yaml, updates tooling (Python 3.12, rattler-build 0.57, vs2022), modernizes CI workflows, adds numerous patches for Boost/C++14 compatibility, and removes legacy additional_recipes in favor of rosdistro_additional_recipes.yaml and pkg_additional_info.yaml.
Changes:
- Unified vinca configuration and removed per-platform
vinca_*.yamlfiles; updatedpixi.tomltasks and CI workflows accordingly - Added/updated many patches for C++14 compatibility, Boost.Asio modernization (
io_service→io_context), and platform-specific fixes - Replaced manual
additional_recipes/withpkg_additional_info.yaml(dummy package generation) androsdistro_additional_recipes.yaml
Reviewed changes
Copilot reviewed 133 out of 136 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vinca_osx_arm64.yaml, vinca_linux_aarch64.yaml | Removed per-platform vinca configs |
| vinca.yaml (implied), pixi.toml | Unified vinca config; updated deps and tasks |
| rosdistro_additional_recipes.yaml | New file for jackal packages bloom recipes |
| robostack.yaml | Updated dependency mappings (cargo, draco, google-mock, etc.) |
| pkg_additional_info.yaml | Replaced build-number overrides with dummy package generation |
| conda_build_config.yaml | Updated pinnings (Python 3.12, protobuf 6.x, vs2022, etc.) |
| patch/* | Many new/updated patches for C++14, Boost.Asio, platform fixes |
| patch/dependencies.yaml | Replaced REQUIRE_OPENGL with explicit per-platform GL deps |
| check_patches_clean_apply.py, build_gap_report.py | New utility scripts |
| .github/workflows/* | Modernized CI with caching, unified recipe generation |
| additional_recipes/* | Removed legacy manually-maintained recipes |
| AGENTS.md | Added developer/agent guidance document |
| constructor_scripts/* | Removed legacy installer scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@traversaro could you have a look at #561? It seems this PR somehow affected |
The main goal here is to align noetic with the rest of the repos, switching to a unified
vinca.yamland similar. To be honest, I do not have any interested in Noetic packages it self at the moment, so if anyone more interested in Noetic wants to help here it would be great.fyi @mmoerdijk @TedVanderfeen @ruben-arts @baszalmstra @vmehta-humanoid @nmarticorena @daenny (just tagging the author of recent PRs to the Noetic repo)