Skip to content

fix(ledger): a report package's block selects its entity #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfrench9 merged 1 commit into from
Oct 9, 2026
Merged

fix(ledger): a report package's block selects its entity #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions clients/LedgerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,13 @@ export type LedgerReconciliationComponent = LedgerReconciliation['components'][n
export type Report = NonNullable<GetLedgerReportQuery['report']>
export type ReportPackage = NonNullable<GetLedgerReportPackageQuery['reportPackage']>
export type ReportPackageItem = ReportPackage['items'][number]
// A report's block renders through the same viewers as a read block, so its
// selection must keep pace with the information-block documents.
type AssertTrue<T extends true> = T
// eslint-disable-next-line @typescript-eslint/no-unused-vars
type ReportBlockIsInformationBlock = AssertTrue<
ReportPackageItem['block'] extends InformationBlock ? true : false
>
export type ReportListItem = NonNullable<ListLedgerReportsQuery['reports']>['reports'][number]
export type StatementData = NonNullable<GetLedgerStatementQuery['statement']>
export type StatementPeriod = StatementData['periods'][number]
Expand Down
2 changes: 2 additions & 0 deletions clients/graphql/generated/graphql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,6 +1545,7 @@ export type GetLedgerReportPackageQuery = {
category: string
taxonomyId: string | null
taxonomyName: string | null
entityId: string | null
informationModel: { conceptArrangement: string | null; memberArrangement: string | null }
artifact: {
topic: string | null
Expand Down Expand Up @@ -6480,6 +6481,7 @@ export const GetLedgerReportPackageDocument = {
{ kind: 'Field', name: { kind: 'Name', value: 'category' } },
{ kind: 'Field', name: { kind: 'Name', value: 'taxonomyId' } },
{ kind: 'Field', name: { kind: 'Name', value: 'taxonomyName' } },
{ kind: 'Field', name: { kind: 'Name', value: 'entityId' } },
{
kind: 'Field',
name: { kind: 'Name', value: 'informationModel' },
Expand Down
1 change: 1 addition & 0 deletions clients/graphql/queries/ledger/reportPackage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export const GET_REPORT_PACKAGE = gql`
category
taxonomyId
taxonomyName
entityId
informationModel {
conceptArrangement
memberArrangement
Expand Down
Loading