Skip to content

feat(ledger): a counterparty's default account, and learning defaults from history - #249

Merged
jfrench9 merged 1 commit into
mainfrom
feature/agent-classification
Oct 11, 2026
Merged

jfrench9 merged 1 commit into
mainfrom
feature/agent-classification

Conversation

@jfrench9

Copy link
Copy Markdown
Member

Summary

Picks up bank-feed classification and bank-line flows from robosystems v1.16.14 (#1775, #1776). A counterparty now carries a default account, learned from its committed bank lines. This exposes the default on agent reads, lets update_agent set it, and adds learn_classification_defaults.

This waits on robosystems v1.16.14 (deploying now). get_agent and list_agents select classification, so they fail validation against a server without it. Release once v1.16.14 is live.

Changes

  • GetLedgerAgent / ListLedgerAgents select classification { elementId accountName mode confirmations overrides setBy setAt learnedFrom }, and the typed models are regenerated (just generate-graphql). It's null until the counterparty has a default.
  • update_agent builds the regenerated UpdateAgentRequest from its dict, so classification_element_id (an empty string clears it) and classification_mode (suggest | always_ask) pass through. The docstring says what they do.
  • New learn_classification_defaults(graph_id, *, dry_run=False).
  • schema.graphql refreshed, and the OpenAPI SDK regenerated, from a local stack on main at v1.16.14. It adds the agent classification models, the learn-defaults operation, and the updated update-event-block description covering a bank line's flow (classified_flow_qname).

Compatibility

Additive: a new nullable field on agent reads, a new facade method, and new optional request fields. The integration template's emit path is untouched. Shipping as a patch on the 2.11 line.

Testing

  • New and updated tests:
    • get_agent parses the classification, and the list fixture carries classification: None;
    • update_agent sends the classification fields;
    • learn_classification_defaults sends dry_run.
  • just test-all: 677 passed, 17 skipped; lint and typecheck clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AQkGGPDmpba9eBV9PkLTfv

… from history

Regenerated against robosystems v1.16.14. get_agent and list_agents select
the agent's classification; update_agent accepts classification_element_id
and classification_mode in its body; learn_classification_defaults is new.

Claude-Session: https://claude.ai/code/session_01AQkGGPDmpba9eBV9PkLTfv
@jfrench9
jfrench9 merged commit e83c9f7 into main Oct 11, 2026
4 checks passed
@jfrench9
jfrench9 deleted the feature/agent-classification branch October 11, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant