Repository navigation
feat(ledger): a counterparty's default account, and learning defaults from history - #249
Merged
Merged
Conversation
… from history Regenerated against robosystems v1.16.14. get_agent and list_agents select the agent's classification; update_agent accepts classification_element_id and classification_mode in its body; learn_classification_defaults is new. Claude-Session: https://claude.ai/code/session_01AQkGGPDmpba9eBV9PkLTfv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up bank-feed classification and bank-line flows from robosystems v1.16.14 (#1775, #1776). A counterparty now carries a default account, learned from its committed bank lines. This exposes the default on agent reads, lets
update_agentset it, and addslearn_classification_defaults.This waits on robosystems v1.16.14 (deploying now).
get_agentandlist_agentsselectclassification, so they fail validation against a server without it. Release once v1.16.14 is live.Changes
GetLedgerAgent/ListLedgerAgentsselectclassification { elementId accountName mode confirmations overrides setBy setAt learnedFrom }, and the typed models are regenerated (just generate-graphql). It's null until the counterparty has a default.update_agentbuilds the regeneratedUpdateAgentRequestfrom its dict, soclassification_element_id(an empty string clears it) andclassification_mode(suggest|always_ask) pass through. The docstring says what they do.learn_classification_defaults(graph_id, *, dry_run=False).schema.graphqlrefreshed, and the OpenAPI SDK regenerated, from a local stack onmainat v1.16.14. It adds the agent classification models, the learn-defaults operation, and the updatedupdate-event-blockdescription covering a bank line's flow (classified_flow_qname).Compatibility
Additive: a new nullable field on agent reads, a new facade method, and new optional request fields. The integration template's emit path is untouched. Shipping as a patch on the 2.11 line.
Testing
get_agentparses the classification, and the list fixture carriesclassification: None;update_agentsends the classification fields;learn_classification_defaultssendsdry_run.just test-all: 677 passed, 17 skipped; lint and typecheck clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01AQkGGPDmpba9eBV9PkLTfv