Repository navigation
feat(ledger): statement cycle, outstanding lines and roll-forward on reconciliations - #248
Merged
Merged
Conversation
…reconciliations Regenerated against robosystems #1771. set_reconciliation_policy takes a statement_cycle; list_reconciliations selects statementCycle, each component's kind, postingDate and entryId, and a statement's rollForward. Claude-Session: https://claude.ai/code/session_01AQkGGPDmpba9eBV9PkLTfv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up bank reconciliation by statement cycle from robosystems #1771. A statement reconciliation now has a cycle (monthly, quarterly or annual). On an account a bank feed keeps, its components list the ledger lines the bank had not cleared. A statement that ends before the period's last day carries a roll-forward to that day.
This waits on robosystems #1771 (merged, not yet released).
ListLedgerReconciliationsselectsstatementCycle,rollForwardand the new component fields, so it fails validation against a server without them. Release this once the next server release carrying #1771 is deployed, or together with it.Changes
LedgerClient.set_reconciliation_policytakesstatement_cycle(monthly,quarterly,annual).ListLedgerReconciliations.graphqlselectsstatementCycle,rollForward, and the component fieldskind,postingDateandentryId. The typed models are regenerated (just generate-graphql).schema.graphqlrefreshed, and the OpenAPI SDK regenerated, from a local stack serving #1771. The generated changes are only this feature:statement_cycleon the policy request, the policy response and the mechanics;ReconciliationRollForward;record_statement_balance,refresh_reconciliations,set_reconciliation_policy) return the generated models, so they carry the new fields as regenerated.Compatibility
Additive: one new keyword argument on a facade method, plus new optional fields on generated models. The integration template's emit path is untouched. Shipping as a patch on the 2.11 line.
Testing
list_reconciliations, andset_reconciliation_policysendsstatement_cycle. The existing list fixture now carries the new fields.just test-all: 675 passed, 17 skipped; lint and typecheck clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01AQkGGPDmpba9eBV9PkLTfv