Repository navigation
feat(ledger): event blocks carry the document they rest on - #247
Merged
Merged
Conversation
get_event_block and list_event_blocks select documentId, so a caller can
see the bill, receipt or statement an event cites. Set it through
update_event_block's document_id ("" detaches). schema.graphql refreshed.
Claude-Session: https://claude.ai/code/session_01AQkGGPDmpba9eBV9PkLTfv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_event_blockandlist_event_blocksnow selectdocumentId, so their models carry the stored document an event cites. Setting the field already works throughupdate_event_block:document_id, where""detaches.This waits on robosystems #1769, which adds
EventBlock.documentIdto the GraphQL schema. These queries select the field, so against a server without it they fail validation. Per the client contract, open it ready and release it once #1769 is deployed (or with it).Contract tier
Additive to the stable tier: a new nullable field on two facade return types. That makes it a client minor or patch.
Test plan
schema.graphqlrefreshed from a local stack serving #1769 (one line,documentId: String), and the GraphQL models regenerated.get_event_blockreturnsdocument_id, and the list fixture carries it.just test-allpasses: 673 tests, ruff and basedpyright clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01AQkGGPDmpba9eBV9PkLTfv